Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-1011: Fix the TimePicker validator regex in the Start Visit form #509

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Jan 18, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

The regular expression supplied to the pattern prop of the TimePicker input in the Start Visit form isn't working as it should. It's currently excluding some valid dates.

This commit fixes the regex so it matches all valid 12-hour clock time values.

Screenshots

The tooltip below was incorrectly shown for a visit started at 3:14 PM.

Screenshot 2022-01-12 at 15 16 53

The regular expression supplied to the pattern prop of the TimePicker input in the Start Visit form isn't working as it should. It's currently excluding some valid dates. This commit fixes it so it matches all valid 12-hour clock values.
@denniskigen denniskigen changed the title O3-1011: Fix Start Visit form time picker validator regex O3-1011: Fix the TimePicker validator regex in the Start Visit form Jan 18, 2022
@github-actions
Copy link
Contributor

File size impact

Merging O3-1011 into master impact files as follow:

@openmrs/esm-form-entry-app (no impact)
Files new size
Unmodified (4) 1.13 MB (0 B / +0%) 👻
Total (4) 1.13 MB (0 B / +0%) 👻
@openmrs/esm-generic-patient-widgets-app (no impact)
Files new size
Unmodified (17) 2.88 MB (0 B / +0%) 👻
Total (17) 2.88 MB (0 B / +0%) 👻
@openmrs/esm-patient-allergies-app (no impact)
Files new size
Unmodified (33) 2.56 MB (0 B / +0%) 👻
Total (33) 2.56 MB (0 B / +0%) 👻
@openmrs/esm-patient-appointments-app (no impact)
Files new size
Unmodified (25) 2.01 MB (0 B / +0%) 👻
Total (25) 2.01 MB (0 B / +0%) 👻
@openmrs/esm-patient-attachments-app (no impact)
Files new size
Unmodified (23) 1.58 MB (0 B / +0%) 👻
Total (23) 1.58 MB (0 B / +0%) 👻
@openmrs/esm-patient-banner-app (no impact)
Files new size
Unmodified (16) 988 kB (0 B / +0%) 👻
Total (16) 988 kB (0 B / +0%) 👻
@openmrs/esm-patient-biometrics-app (no impact)
Files new size
Unmodified (23) 2.5 MB (0 B / +0%) 👻
Total (23) 2.5 MB (0 B / +0%) 👻
@openmrs/esm-patient-chart-app (-0%)
Files new size
packages/esm-patient-chart-app/dist/959.js 278 kB (-1 B / -0%) ↘️
Unmodified (39) 3.08 MB (0 B / +0%) 👻
Total (40) 3.36 MB (-1 B / -0%) ↘️
@openmrs/esm-patient-clinical-view-app (no impact)
Files new size
Unmodified (21) 1.38 MB (0 B / +0%) 👻
Total (21) 1.38 MB (0 B / +0%) 👻
@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}
@openmrs/esm-patient-conditions-app (no impact)
Files new size
Unmodified (24) 1.86 MB (0 B / +0%) 👻
Total (24) 1.86 MB (0 B / +0%) 👻
@openmrs/esm-patient-forms-app (no impact)
Files new size
Unmodified (28) 1.98 MB (0 B / +0%) 👻
Total (28) 1.98 MB (0 B / +0%) 👻
@openmrs/esm-patient-immunizations-app (no impact)
Files new size
Unmodified (25) 1.83 MB (0 B / +0%) 👻
Total (25) 1.83 MB (0 B / +0%) 👻
@openmrs/esm-patient-medications-app (no impact)
Files new size
Unmodified (21) 2.86 MB (0 B / +0%) 👻
Total (21) 2.86 MB (0 B / +0%) 👻
@openmrs/esm-patient-notes-app (no impact)
Files new size
Unmodified (25) 1.82 MB (0 B / +0%) 👻
Total (25) 1.82 MB (0 B / +0%) 👻
@openmrs/esm-patient-programs-app (no impact)
Files new size
Unmodified (24) 1.84 MB (0 B / +0%) 👻
Total (24) 1.84 MB (0 B / +0%) 👻
@openmrs/esm-patient-test-results-app (no impact)
Files new size
Unmodified (21) 3.71 MB (0 B / +0%) 👻
Total (21) 3.71 MB (0 B / +0%) 👻
@openmrs/esm-patient-vitals-app (no impact)
Files new size
Unmodified (27) 3.44 MB (0 B / +0%) 👻
Total (27) 3.44 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#1712716581 on 8544d0f

Copy link
Member

@jonathandick jonathandick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathandick jonathandick merged commit d3c07ff into master Jan 18, 2022
@donaldkibet donaldkibet deleted the O3-1011 branch April 23, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants