Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old workspace implementation #516

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Remove old workspace implementation #516

merged 1 commit into from
Jan 20, 2022

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Jan 20, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 style guide.
  • I checked for feature overlap with existing widgets.

Summary

This PR removes the old implementation of the workspace. This code is no longer in use and maintaining multiple workspace implementations only yields confusion.

@github-actions
Copy link
Contributor

File size impact

Merging old-workspace-impl into master impact files as follow:

@openmrs/esm-form-entry-app (no impact)
Files new size
Unmodified (4) 1.13 MB (0 B / +0%) 👻
Total (4) 1.13 MB (0 B / +0%) 👻
@openmrs/esm-generic-patient-widgets-app (no impact)
Files new size
Unmodified (17) 2.88 MB (0 B / +0%) 👻
Total (17) 2.88 MB (0 B / +0%) 👻
@openmrs/esm-patient-allergies-app (no impact)
Files new size
Unmodified (33) 2.56 MB (0 B / +0%) 👻
Total (33) 2.56 MB (0 B / +0%) 👻
@openmrs/esm-patient-appointments-app (no impact)
Files new size
Unmodified (25) 2.01 MB (0 B / +0%) 👻
Total (25) 2.01 MB (0 B / +0%) 👻
@openmrs/esm-patient-attachments-app (no impact)
Files new size
Unmodified (23) 1.58 MB (0 B / +0%) 👻
Total (23) 1.58 MB (0 B / +0%) 👻
@openmrs/esm-patient-banner-app (no impact)
Files new size
Unmodified (16) 988 kB (0 B / +0%) 👻
Total (16) 988 kB (0 B / +0%) 👻
@openmrs/esm-patient-biometrics-app (no impact)
Files new size
Unmodified (23) 2.5 MB (0 B / +0%) 👻
Total (23) 2.5 MB (0 B / +0%) 👻
@openmrs/esm-patient-chart-app (-0.36%)
Files new size
packages/esm-patient-chart-app/dist/297.js 886 kB 👶
packages/esm-patient-chart-app/dist/87.js 9.53 kB (+3 B / +0.03%) ↗️
packages/esm-patient-chart-app/dist/33.js deleted (-898 kB)
Unmodified (38) 2.45 MB (0 B / +0%) 👻
Total (41) 3.35 MB (-12.1 kB / -0.36%) ↘️
@openmrs/esm-patient-clinical-view-app (no impact)
Files new size
Unmodified (21) 1.38 MB (0 B / +0%) 👻
Total (21) 1.38 MB (0 B / +0%) 👻
@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}
@openmrs/esm-patient-conditions-app (no impact)
Files new size
Unmodified (24) 1.86 MB (0 B / +0%) 👻
Total (24) 1.86 MB (0 B / +0%) 👻
@openmrs/esm-patient-forms-app (no impact)
Files new size
Unmodified (28) 1.98 MB (0 B / +0%) 👻
Total (28) 1.98 MB (0 B / +0%) 👻
@openmrs/esm-patient-immunizations-app (no impact)
Files new size
Unmodified (25) 1.83 MB (0 B / +0%) 👻
Total (25) 1.83 MB (0 B / +0%) 👻
@openmrs/esm-patient-medications-app (no impact)
Files new size
Unmodified (21) 2.86 MB (0 B / +0%) 👻
Total (21) 2.86 MB (0 B / +0%) 👻
@openmrs/esm-patient-notes-app (no impact)
Files new size
Unmodified (25) 1.82 MB (0 B / +0%) 👻
Total (25) 1.82 MB (0 B / +0%) 👻
@openmrs/esm-patient-programs-app (no impact)
Files new size
Unmodified (24) 1.84 MB (0 B / +0%) 👻
Total (24) 1.84 MB (0 B / +0%) 👻
@openmrs/esm-patient-test-results-app (no impact)
Files new size
Unmodified (21) 3.71 MB (0 B / +0%) 👻
Total (21) 3.71 MB (0 B / +0%) 👻
@openmrs/esm-patient-vitals-app (no impact)
Files new size
Unmodified (27) 3.44 MB (0 B / +0%) 👻
Total (27) 3.44 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#1722976148 on 5d8473a

Copy link
Contributor

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Thanks Dennis!

@brandones brandones merged commit 32fd803 into master Jan 20, 2022
@brandones brandones deleted the old-workspace-impl branch January 20, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants