O3-1027: Encounters view should use the encounter time

[ibacher]

Requirements

• This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
• My work conforms to the OpenMRS 3.0 Styleguide.
• I checked for feature overlap with existing widgets.

Summary

Fixes a typo that caused the encounter date to always be undefined.

Screenshots

Issue

https://issues.openmrs.org/browse/O3-1027

Other

None.

[github-actions]

File size impact

Merging O3-1027 into master impact files as follow:

@openmrs/esm-form-entry-app (no impact)

Files	new size
Unmodified (4)	1.47 MB (0 B / +0%)	👻
Total (4)	1.47 MB (0 B / +0%)	👻

@openmrs/esm-generic-patient-widgets-app (no impact)

Files	new size
Unmodified (16)	2.92 MB (0 B / +0%)	👻
Total (16)	2.92 MB (0 B / +0%)	👻

@openmrs/esm-patient-allergies-app (no impact)

Files	new size
Unmodified (33)	2.59 MB (0 B / +0%)	👻
Total (33)	2.59 MB (0 B / +0%)	👻

@openmrs/esm-patient-appointments-app (no impact)

Files	new size
Unmodified (25)	2.06 MB (0 B / +0%)	👻
Total (25)	2.06 MB (0 B / +0%)	👻

@openmrs/esm-patient-attachments-app (no impact)

Files	new size
Unmodified (22)	1.61 MB (0 B / +0%)	👻
Total (22)	1.61 MB (0 B / +0%)	👻

@openmrs/esm-patient-banner-app (no impact)

Files	new size
Unmodified (17)	1.01 MB (0 B / +0%)	👻
Total (17)	1.01 MB (0 B / +0%)	👻

@openmrs/esm-patient-biometrics-app (no impact)

Files	new size
Unmodified (22)	2.54 MB (0 B / +0%)	👻
Total (22)	2.54 MB (0 B / +0%)	👻

@openmrs/esm-patient-chart-app (+0%)

Files	new size
packages/esm-patient-chart-app/dist/922.js	161 kB (+1 B / +0%)	↗️
Unmodified (40)	3.36 MB (0 B / +0%)	👻
Total (41)	3.52 MB (+1 B / +0%)	↗️

@openmrs/esm-patient-clinical-view-app (no impact)

Files	new size
Unmodified (20)	1.41 MB (0 B / +0%)	👻
Total (20)	1.41 MB (0 B / +0%)	👻

@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}

@openmrs/esm-patient-conditions-app (no impact)

Files	new size
Unmodified (26)	1.92 MB (0 B / +0%)	👻
Total (26)	1.92 MB (0 B / +0%)	👻

@openmrs/esm-patient-forms-app (no impact)

Files	new size
Unmodified (26)	1.97 MB (0 B / +0%)	👻
Total (26)	1.97 MB (0 B / +0%)	👻

@openmrs/esm-patient-immunizations-app (no impact)

Files	new size
Unmodified (23)	1.82 MB (0 B / +0%)	👻
Total (23)	1.82 MB (0 B / +0%)	👻

@openmrs/esm-patient-medications-app (no impact)

Files	new size
Unmodified (20)	2.78 MB (0 B / +0%)	👻
Total (20)	2.78 MB (0 B / +0%)	👻

@openmrs/esm-patient-notes-app (no impact)

Files	new size
Unmodified (25)	1.85 MB (0 B / +0%)	👻
Total (25)	1.85 MB (0 B / +0%)	👻

@openmrs/esm-patient-programs-app (no impact)

Files	new size
Unmodified (23)	1.87 MB (0 B / +0%)	👻
Total (23)	1.87 MB (0 B / +0%)	👻

@openmrs/esm-patient-test-results-app (no impact)

Files	new size
Unmodified (23)	3.78 MB (0 B / +0%)	👻
Total (23)	3.78 MB (0 B / +0%)	👻

@openmrs/esm-patient-vitals-app (no impact)

Files	new size
Unmodified (26)	3.49 MB (0 B / +0%)	👻
Total (26)	3.49 MB (0 B / +0%)	👻

_{Generated by @jsenv/file-size-impact during Report bundle size#1763690175 on dad300b}

[ibacher]

Hmmm... can't reproduce the TS error locally. Will look into tomorrow.

[brandones]

Oh strange, I'm used to seeing that one when I'm doing yarn link @openmrs/esm-xyz. In that case I hack around it by adding

    "paths": {
      "@openmrs/*": ["./node_modules/@openmrs/*"]
    },

to the .tsconfig. Which I should probably note in the README for esm-core.

But why it would be appearing in CI is a mystery to me.