Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-1021: Make the offline visit type UUID configurable. #528

Conversation

manuelroemer
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Makes the offline visit type UUID configurable.

Screenshots

None.

Issue

https://issues.openmrs.org/browse/O3-1021

Other

None.

@manuelroemer
Copy link
Member Author

Happy about any comments whether I'm using the config API right - it's the first time I'm actively using it.

Also, does anybody know an account which can access the implementer tools? They don't appear for me with the admin2 account.

Copy link
Contributor

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @manuelroemer !

EDIT: Oh wait, we need to make sure to register the schema. Use defineConfigSchema in your index file. See docs.

EDIT EDIT: Oh, just looked at the index, it's already there. All good!

@jonathandick
Copy link
Member

I'm not sure how to interpret the failing file size. I'm guessing it's safe to merge. But want to make sure @manuelroemer

… into feature/O3-1021-offline-visit-type-configuration
@manuelroemer manuelroemer merged commit 069d510 into openmrs:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants