Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-1072: Remove unused notifications menu implementation #541

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Feb 8, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

We currently have a notifications menu implementation in the side rail that's not in use. Moreover, it is a duplicate of similar code in the primary-navigation app that is further developed and actively in use at AMPATH. Upon consultation with Ciaran, we've elected to remove this bit of code.

Screenshots

Screenshot 2022-02-08 at 17 01 05

Screenshot 2022-02-08 at 17 02 22

Screenshot 2022-02-08 at 17 10 01

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

File size impact

Merging O3-1072 into master impact files as follow:

@openmrs/esm-form-entry-app (no impact)
Files new size
Unmodified (4) 1.47 MB (0 B / +0%) 👻
Total (4) 1.47 MB (0 B / +0%) 👻
@openmrs/esm-generic-patient-widgets-app (no impact)
Files new size
Unmodified (16) 2.92 MB (0 B / +0%) 👻
Total (16) 2.92 MB (0 B / +0%) 👻
@openmrs/esm-patient-allergies-app (no impact)
Files new size
Unmodified (33) 2.58 MB (0 B / +0%) 👻
Total (33) 2.58 MB (0 B / +0%) 👻
@openmrs/esm-patient-appointments-app (no impact)
Files new size
Unmodified (25) 2.06 MB (0 B / +0%) 👻
Total (25) 2.06 MB (0 B / +0%) 👻
@openmrs/esm-patient-attachments-app (no impact)
Files new size
Unmodified (22) 1.61 MB (0 B / +0%) 👻
Total (22) 1.61 MB (0 B / +0%) 👻
@openmrs/esm-patient-banner-app (no impact)
Files new size
Unmodified (17) 1.01 MB (0 B / +0%) 👻
Total (17) 1.01 MB (0 B / +0%) 👻
@openmrs/esm-patient-biometrics-app (no impact)
Files new size
Unmodified (22) 2.54 MB (0 B / +0%) 👻
Total (22) 2.54 MB (0 B / +0%) 👻
@openmrs/esm-patient-chart-app (-0.05%)
Files new size
packages/esm-patient-chart-app/dist/937.js 1.04 MB 👶
packages/esm-patient-chart-app/dist/93.js 30 kB 👶
packages/esm-patient-chart-app/dist/openmrs-esm-patient-chart-app.js 8.53 kB (-20 B / -0.23%) ↘️
packages/esm-patient-chart-app/dist/87.js 10.5 kB (-267 B / -2.48%) ↘️
packages/esm-patient-chart-app/dist/40.js deleted (-1.17 kB)
packages/esm-patient-chart-app/dist/197.js deleted (-5.14 kB)
packages/esm-patient-chart-app/dist/930.js deleted (-24.8 kB)
packages/esm-patient-chart-app/dist/678.js deleted (-141 kB)
packages/esm-patient-chart-app/dist/666.js deleted (-896 kB)
Unmodified (36) 2.47 MB (0 B / +0%) 👻
Total (45) 3.55 MB (-1.82 kB / -0.05%) ↘️
@openmrs/esm-patient-clinical-view-app (no impact)
Files new size
Unmodified (19) 1.42 MB (0 B / +0%) 👻
Total (19) 1.42 MB (0 B / +0%) 👻
@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}
@openmrs/esm-patient-conditions-app (no impact)
Files new size
Unmodified (26) 1.91 MB (0 B / +0%) 👻
Total (26) 1.91 MB (0 B / +0%) 👻
@openmrs/esm-patient-forms-app (no impact)
Files new size
Unmodified (25) 1.98 MB (0 B / +0%) 👻
Total (25) 1.98 MB (0 B / +0%) 👻
@openmrs/esm-patient-immunizations-app (no impact)
Files new size
Unmodified (23) 1.82 MB (0 B / +0%) 👻
Total (23) 1.82 MB (0 B / +0%) 👻
@openmrs/esm-patient-medications-app (no impact)
Files new size
Unmodified (20) 2.78 MB (0 B / +0%) 👻
Total (20) 2.78 MB (0 B / +0%) 👻
@openmrs/esm-patient-notes-app (no impact)
Files new size
Unmodified (25) 1.85 MB (0 B / +0%) 👻
Total (25) 1.85 MB (0 B / +0%) 👻
@openmrs/esm-patient-programs-app (no impact)
Files new size
Unmodified (23) 1.87 MB (0 B / +0%) 👻
Total (23) 1.87 MB (0 B / +0%) 👻
@openmrs/esm-patient-test-results-app (no impact)
Files new size
Unmodified (23) 3.78 MB (0 B / +0%) 👻
Total (23) 3.78 MB (0 B / +0%) 👻
@openmrs/esm-patient-vitals-app (no impact)
Files new size
Unmodified (26) 3.49 MB (0 B / +0%) 👻
Total (26) 3.49 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#1812725810 on 5ab333c

@brandones brandones merged commit 5e6a6df into master Feb 8, 2022
@brandones brandones deleted the O3-1072 branch February 8, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants