O3-1023 Should be possible to launch patient chart with workspace open #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibacher I opted not to implement this using the URL bar because of some questions I hadn't finished thinking through—namely I wasn't sure how to deal with workspace props provided at launch time. I now think those props should probably just be serialized to the URL bar? But anyway that's a different problem for a different ticket. |
|
Note—JJ pointed out that in my gif the workspace doesn't go to the bottom of the screen. That doesn't have to do with this PR. Probably just something out of date with my dev server. |
|
Oh, this might not be working for other reasons though. Will notify once it's confirmed in good shape. |
|
j/k I think it's fine |
File size impactMerging workspace-launch into master impact files as follow: @openmrs/esm-form-entry-app (no impact)
@openmrs/esm-generic-patient-widgets-app (+0.01%)
@openmrs/esm-patient-allergies-app (+0.01%)
@openmrs/esm-patient-appointments-app (+0.01%)
@openmrs/esm-patient-attachments-app (+0.02%)
@openmrs/esm-patient-banner-app (no impact)
@openmrs/esm-patient-biometrics-app (+0.01%)
@openmrs/esm-patient-chart-app (+0.01%)
@openmrs/esm-patient-clinical-view-app (+0.02%)
@openmrs/esm-patient-common-lib (no impact)No file in @openmrs/esm-patient-common-lib group (see config below). {
"./packages/esm-patient-common-lib/dist/*.js": true,
"./packages/esm-patient-common-lib/dist/*.css": true,
"./packages/esm-patient-common-lib/dist/*.map": false,
"./packages/esm-patient-common-lib/dist/*.txt": false,
"./packages/esm-patient-common-lib/dist/*.json": false
}@openmrs/esm-patient-conditions-app (+0.01%)
@openmrs/esm-patient-forms-app (+0.01%)
@openmrs/esm-patient-immunizations-app (+0.01%)
@openmrs/esm-patient-medications-app (+0.01%)
@openmrs/esm-patient-notes-app (+0.01%)
@openmrs/esm-patient-programs-app (+0.01%)
@openmrs/esm-patient-test-results-app (+0.01%)
@openmrs/esm-patient-vitals-app (+0.01%)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This makes it possible to launch the patient chart with a workspace open.
Screenshots
Issue
https://issues.openmrs.org/browse/O3-1023