Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) The intermittent 'Cannot redeclare block-scoped variable' type error #561

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

brandones
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Prevents this error:

 Error: ../../node_modules/@openmrs/esm-framework/node_modules/@openmrs/esm-globals/src/types.ts(51,9): error TS2451: Cannot redeclare block-scoped variable '__webpack_init_sharing__'.

@github-actions
Copy link
Contributor

File size impact

Merging fix-dupe-decl-err into master impact files as follow:

@openmrs/esm-form-entry-app (+8.02%)
Files new size
packages/esm-form-entry-app/dist/1.openmrs-esm-form-entry-app.js 1.48 MB (+109 kB / +7.92%) ↗️
packages/esm-form-entry-app/dist/openmrs-esm-form-entry-app.js 84.5 kB (+5.83 kB / +7.41%) ↗️
packages/esm-form-entry-app/dist/2.openmrs-esm-form-entry-app.js 46.5 kB (+5.21 kB / +12.59%) ↗️
Unmodified (1) 155 B (0 B / +0%) 👻
Total (4) 1.62 MB (+120 kB / +8.02%) ↗️
@openmrs/esm-generic-patient-widgets-app (no impact)
Files new size
Unmodified (14) 2.9 MB (0 B / +0%) 👻
Total (14) 2.9 MB (0 B / +0%) 👻
@openmrs/esm-patient-allergies-app (no impact)
Files new size
Unmodified (32) 2.57 MB (0 B / +0%) 👻
Total (32) 2.57 MB (0 B / +0%) 👻
@openmrs/esm-patient-appointments-app (no impact)
Files new size
Unmodified (24) 2.05 MB (0 B / +0%) 👻
Total (24) 2.05 MB (0 B / +0%) 👻
@openmrs/esm-patient-attachments-app (no impact)
Files new size
Unmodified (19) 1.6 MB (0 B / +0%) 👻
Total (19) 1.6 MB (0 B / +0%) 👻
@openmrs/esm-patient-banner-app (no impact)
Files new size
Unmodified (15) 992 kB (0 B / +0%) 👻
Total (15) 992 kB (0 B / +0%) 👻
@openmrs/esm-patient-biometrics-app (no impact)
Files new size
Unmodified (21) 2.53 MB (0 B / +0%) 👻
Total (21) 2.53 MB (0 B / +0%) 👻
@openmrs/esm-patient-chart-app (no impact)
Files new size
Unmodified (40) 3.57 MB (0 B / +0%) 👻
Total (40) 3.57 MB (0 B / +0%) 👻
@openmrs/esm-patient-clinical-view-app (no impact)
Files new size
Unmodified (18) 1.41 MB (0 B / +0%) 👻
Total (18) 1.41 MB (0 B / +0%) 👻
@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}
@openmrs/esm-patient-conditions-app (no impact)
Files new size
Unmodified (25) 1.9 MB (0 B / +0%) 👻
Total (25) 1.9 MB (0 B / +0%) 👻
@openmrs/esm-patient-forms-app (no impact)
Files new size
Unmodified (24) 1.97 MB (0 B / +0%) 👻
Total (24) 1.97 MB (0 B / +0%) 👻
@openmrs/esm-patient-immunizations-app (no impact)
Files new size
Unmodified (21) 1.81 MB (0 B / +0%) 👻
Total (21) 1.81 MB (0 B / +0%) 👻
@openmrs/esm-patient-medications-app (no impact)
Files new size
Unmodified (19) 2.77 MB (0 B / +0%) 👻
Total (19) 2.77 MB (0 B / +0%) 👻
@openmrs/esm-patient-notes-app (no impact)
Files new size
Unmodified (24) 1.93 MB (0 B / +0%) 👻
Total (24) 1.93 MB (0 B / +0%) 👻
@openmrs/esm-patient-programs-app (no impact)
Files new size
Unmodified (22) 1.86 MB (0 B / +0%) 👻
Total (22) 1.86 MB (0 B / +0%) 👻
@openmrs/esm-patient-test-results-app (no impact)
Files new size
Unmodified (26) 3.77 MB (0 B / +0%) 👻
Total (26) 3.77 MB (0 B / +0%) 👻
@openmrs/esm-patient-vitals-app (no impact)
Files new size
Unmodified (25) 3.58 MB (0 B / +0%) 👻
Total (25) 3.58 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#1860142711 on 1be5418

@denniskigen
Copy link
Member

And the award for most annoying type error goes to... drumroll.

Thanks for fixing this!

@denniskigen denniskigen merged commit 71f8830 into master Feb 17, 2022
@denniskigen denniskigen deleted the fix-dupe-decl-err branch February 17, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants