Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(enhancement) improve mechanism of fetching biometrics and vital signs #567

Merged
merged 1 commit into from
Feb 20, 2022

Conversation

donaldkibet
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

  • Improve mechanism of fetching biometrics and vitals, handles a number of issues
  • remove sorting from the front-end as this has already been done by the backend
  • remove bug where the vitals-header component indicated No vitals and biometrics recorded when biometrics are only captured

Screenshots

error state

Screenshot 2022-02-19 at 08 20 18

fix

Screenshot 2022-02-19 at 08 27 12

Issue

None.

Other

None.

Copy link
Member

@jonathandick jonathandick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@github-actions
Copy link
Contributor


Error: Error while trying to collect info after merging biometrics/vitals into master.

Error: Command failed: git merge FETCH_HEAD --allow-unrelated-histories

    at ChildProcess.exithandler (node:child_process:397:12)
    at ChildProcess.emit (node:events:394:28)
    at maybeClose (node:internal/child_process:1067:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)

Generated by @jsenv/file-size-impact during Report bundle size#1867904825 on 5fd56c9

@donaldkibet donaldkibet merged commit bcfd849 into master Feb 20, 2022
@donaldkibet donaldkibet deleted the biometrics/vitals branch April 23, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants