-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O3-1114: Adapt encounters widget to match designs #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size impactMerging O3-1114 into master impact files as follow: @openmrs/esm-form-entry-app (+8.02%)
@openmrs/esm-generic-patient-widgets-app (no impact)
@openmrs/esm-patient-allergies-app (no impact)
@openmrs/esm-patient-appointments-app (no impact)
@openmrs/esm-patient-attachments-app (no impact)
@openmrs/esm-patient-banner-app (no impact)
@openmrs/esm-patient-biometrics-app (no impact)
@openmrs/esm-patient-chart-app (+0.21%)
@openmrs/esm-patient-clinical-view-app (no impact)
@openmrs/esm-patient-common-lib (no impact)No file in @openmrs/esm-patient-common-lib group (see config below). {
"./packages/esm-patient-common-lib/dist/*.js": true,
"./packages/esm-patient-common-lib/dist/*.css": true,
"./packages/esm-patient-common-lib/dist/*.map": false,
"./packages/esm-patient-common-lib/dist/*.txt": false,
"./packages/esm-patient-common-lib/dist/*.json": false
} @openmrs/esm-patient-conditions-app (no impact)
@openmrs/esm-patient-forms-app (no impact)
@openmrs/esm-patient-immunizations-app (no impact)
@openmrs/esm-patient-medications-app (no impact)
@openmrs/esm-patient-notes-app (no impact)
@openmrs/esm-patient-programs-app (no impact)
@openmrs/esm-patient-test-results-app (no impact)
@openmrs/esm-patient-vitals-app (no impact)
|
Presently, the encounters widget doesn't quite match the available spec. This PR fixes a whole bunch of design mismatches such as: - Use of a content switcher for toggling between the `Visit summaries` view and the `All encounters` view. Tabs ought to be used instead. - Addition of a missing tab for `Encounters` in Visit summary overview. - Completely redoing the `All encounters` view so that it displays a tabular summary of _all_ the encounters. - Applying visual tweaks to the UI to get it as close as possible to matching the spec.
- Rename the `encounters` dashboard to `visits`. - Show just the encounter `Time` in the Encounters tab summary. The `All Encounters` summary should show both the date and time of an encounter. - Show a simpler empty state for the Encounters tab when no encounter data is available. - Add options for editing an encounter, launching an encounter in the encounters dashboard and deleting an encounter to the overflow actions menu.
A summary of the remaining work:
I expect to tackle these in subsequent pull requests. Their absence here doesn't affect the readiness of this body of work. |
jonathandick
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Presently, the encounters widget doesn't quite match the available spec. This PR rectifies this by providing a whole bunch of design fixes, such as:
Visit summaries
view and theAll encounters
view.Encounters
tab to all visit summaries in theVisit summaries
view. This tab displays a tabular overview of the encounters associated with a visit when present. It's a slightly pared-down version of what you'd see in theAll encounters
tab.All encounters view
to display a tabular overview of all the encounters linked to a patient.Additional changes following a design review from Ciaran:
encounters
dashboard tovisits
.Time
in the encounters tab summary of theVisit Summaries
view. TheAll Encounters
view should show both the encounterDate
andTime
.Screenshots