(enhancement) Add ability to display poc forms only and filter out ht… #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size impactMerging poc-form-config into master impact files as follow: @openmrs/esm-form-entry-app (+8.02%)
@openmrs/esm-generic-patient-widgets-app (no impact)
@openmrs/esm-patient-allergies-app (no impact)
@openmrs/esm-patient-appointments-app (no impact)
@openmrs/esm-patient-attachments-app (no impact)
@openmrs/esm-patient-banner-app (no impact)
@openmrs/esm-patient-biometrics-app (no impact)
@openmrs/esm-patient-chart-app (no impact)
@openmrs/esm-patient-clinical-view-app (no impact)
@openmrs/esm-patient-common-lib (no impact)No file in @openmrs/esm-patient-common-lib group (see config below). {
"./packages/esm-patient-common-lib/dist/*.js": true,
"./packages/esm-patient-common-lib/dist/*.css": true,
"./packages/esm-patient-common-lib/dist/*.map": false,
"./packages/esm-patient-common-lib/dist/*.txt": false,
"./packages/esm-patient-common-lib/dist/*.json": false
}@openmrs/esm-patient-conditions-app (no impact)
@openmrs/esm-patient-forms-app (+0.03%)
@openmrs/esm-patient-immunizations-app (no impact)
@openmrs/esm-patient-medications-app (no impact)
@openmrs/esm-patient-notes-app (no impact)
@openmrs/esm-patient-programs-app (no impact)
@openmrs/esm-patient-test-results-app (no impact)
@openmrs/esm-patient-vitals-app (no impact)
|
brandones
requested changes
Feb 23, 2022
| import { ListResponse, FormEncounter, EncounterWithFormRef, CompletedFormInfo } from '../types'; | ||
| import { customEncounterRepresentation, formEncounterUrl } from '../constants'; | ||
| import { isFormFullyCached } from '../offline-forms/offline-form-helpers'; | ||
|
|
||
| export function useFormEncounters(cachedOfflineFormsOnly = false) { | ||
| return useSWR([formEncounterUrl, cachedOfflineFormsOnly], async () => { | ||
| const res = await openmrsFetch<ListResponse<FormEncounter>>(formEncounterUrl); | ||
| const config = useConfig(); |
There was a problem hiding this comment.
nit: @brandones do we normally declare the config outside of a function?
There was a problem hiding this comment.
Not sure what you mean by "declare the config." This all looks reasonable though. useConfig is a hook, so it's subject to the normal rules of hooks; since useFormEncounters is also a hook, this is usage is good.
| @@ -61,6 +61,11 @@ export const configSchema = { | |||
| }, | |||
| ], | |||
| }, | |||
| displayPOCForms: { | |||
There was a problem hiding this comment.
Also, to my dismay, the term AMPATH Forms, has stucky. I think you are specifically referring her to AMPATH forms when using the term POC. Perhaps replace with AF for now.
There was a problem hiding this comment.
See my requested change above
|
@brandones Thanks for the review. Please look again I have effected the requested changes. |
brandones
approved these changes
Feb 24, 2022
|
Thanks @makombe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ml forms
Requirements
Summary
The PR introduces config to assist with filtering out POC forms(forms created through ampath form builder ) from html forms. When config is set you will only be able to fetch published poc forms.
Screenshots
None.
Issue
None.
Other
None.