Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-1103: (feat) Further enhancements to the vitals widget #577

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Feb 25, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

This PR makes the following enhancements to the vitals widget:

  • Factor out the VitalsHeaderTitle component into the VitalsHeader component. This centralises all the vitals header concerns under one main component - VitalsHeader.
  • Add interpretations for heart rate, pulse and respiratory rate values so abnormal values get flagged.
  • Add helper functions that simplify assessing vital signs to determine abnormal values.
  • Add various style fixes.

Screenshots

Screenshot 2022-02-25 at 16 32 32

This PR makes the following enhancements to the vitals widget:

- Factor out the `VitalsHeaderTitle` component into the `VitalsHeader` component. This centralises all the vitals header concerns under one main component - `VitalsHeader`.
- Add `interpretation`s for `heart rate`, `pulse` and `respiratory rate` values so abnormal values get flagged.
- Add helper functions that simplify assessing vital signs to determine abnormal values.
- Add various style fixes.
@github-actions
Copy link
Contributor

File size impact

Merging O3-1103-next into master impact files as follow:

@openmrs/esm-form-entry-app (+8.02%)
Files new size
packages/esm-form-entry-app/dist/1.openmrs-esm-form-entry-app.js 1.48 MB (+109 kB / +7.92%) ↗️
packages/esm-form-entry-app/dist/openmrs-esm-form-entry-app.js 84.5 kB (+5.83 kB / +7.41%) ↗️
packages/esm-form-entry-app/dist/2.openmrs-esm-form-entry-app.js 46.5 kB (+5.21 kB / +12.59%) ↗️
Unmodified (1) 155 B (0 B / +0%) 👻
Total (4) 1.62 MB (+120 kB / +8.02%) ↗️
@openmrs/esm-generic-patient-widgets-app (no impact)
Files new size
Unmodified (14) 2.9 MB (0 B / +0%) 👻
Total (14) 2.9 MB (0 B / +0%) 👻
@openmrs/esm-patient-allergies-app (no impact)
Files new size
Unmodified (32) 2.57 MB (0 B / +0%) 👻
Total (32) 2.57 MB (0 B / +0%) 👻
@openmrs/esm-patient-appointments-app (no impact)
Files new size
Unmodified (24) 2.05 MB (0 B / +0%) 👻
Total (24) 2.05 MB (0 B / +0%) 👻
@openmrs/esm-patient-attachments-app (no impact)
Files new size
Unmodified (19) 1.6 MB (0 B / +0%) 👻
Total (19) 1.6 MB (0 B / +0%) 👻
@openmrs/esm-patient-banner-app (no impact)
Files new size
Unmodified (15) 992 kB (0 B / +0%) 👻
Total (15) 992 kB (0 B / +0%) 👻
@openmrs/esm-patient-biometrics-app (no impact)
Files new size
Unmodified (21) 2.53 MB (0 B / +0%) 👻
Total (21) 2.53 MB (0 B / +0%) 👻
@openmrs/esm-patient-chart-app (no impact)
Files new size
Unmodified (40) 3.58 MB (0 B / +0%) 👻
Total (40) 3.58 MB (0 B / +0%) 👻
@openmrs/esm-patient-clinical-view-app (no impact)
Files new size
Unmodified (18) 1.41 MB (0 B / +0%) 👻
Total (18) 1.41 MB (0 B / +0%) 👻
@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}
@openmrs/esm-patient-conditions-app (no impact)
Files new size
Unmodified (25) 1.91 MB (0 B / +0%) 👻
Total (25) 1.91 MB (0 B / +0%) 👻
@openmrs/esm-patient-forms-app (no impact)
Files new size
Unmodified (24) 1.97 MB (0 B / +0%) 👻
Total (24) 1.97 MB (0 B / +0%) 👻
@openmrs/esm-patient-immunizations-app (no impact)
Files new size
Unmodified (21) 1.81 MB (0 B / +0%) 👻
Total (21) 1.81 MB (0 B / +0%) 👻
@openmrs/esm-patient-medications-app (no impact)
Files new size
Unmodified (19) 2.77 MB (0 B / +0%) 👻
Total (19) 2.77 MB (0 B / +0%) 👻
@openmrs/esm-patient-notes-app (no impact)
Files new size
Unmodified (24) 1.94 MB (0 B / +0%) 👻
Total (24) 1.94 MB (0 B / +0%) 👻
@openmrs/esm-patient-programs-app (no impact)
Files new size
Unmodified (21) 1.91 MB (0 B / +0%) 👻
Total (21) 1.91 MB (0 B / +0%) 👻
@openmrs/esm-patient-test-results-app (no impact)
Files new size
Unmodified (27) 3.92 MB (0 B / +0%) 👻
Total (27) 3.92 MB (0 B / +0%) 👻
@openmrs/esm-patient-vitals-app (-3.78%)
Files new size
packages/esm-patient-vitals-app/dist/379.js 290 kB 👶
packages/esm-patient-vitals-app/dist/323.js deleted (-425 kB)
packages/esm-patient-vitals-app/dist/486.js 3.36 kB (0 B / +0%) 👻
packages/esm-patient-vitals-app/dist/574.js 1.39 kB (0 B / +0%) 👻
packages/esm-patient-vitals-app/dist/openmrs-esm-patient-vitals-app.js 11.4 kB (0 B / +0%) 👻
Unmodified (21) 3.14 MB (0 B / +0%) 👻
Total (26) 3.44 MB (-135 kB / -3.78%) ↘️
Generated by @jsenv/file-size-impact during Report bundle size#1898894626 on 276418a

@jonathandick jonathandick merged commit 2cea2a7 into master Feb 25, 2022
@ibacher ibacher deleted the O3-1103-next branch January 16, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants