Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) first step to add ability to display recommended visit-type and forms #590

Merged
merged 5 commits into from
Mar 9, 2022

Conversation

donaldkibet
Copy link
Member

@donaldkibet donaldkibet commented Mar 3, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

This is WIP on adding the ability to display recommended visit-type and forms based on patient program enrolment.
This PR address Ampath workflow with additional work to be put in place to generically config how recommended forms and visit type should be done, this should be considered as the first initial set to that goal.

Screenshots

workflow

Related Issue

Other

TODO: Make this workflow configurable

@donaldkibet donaldkibet requested a review from jonathandick March 3, 2022 08:24
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

File size impact

Merging feature/recommended-visits into master impact files as follow:

@openmrs/esm-form-entry-app (+8.02%)
Files new size
packages/esm-form-entry-app/dist/1.openmrs-esm-form-entry-app.js 1.48 MB (+109 kB / +7.92%) ↗️
packages/esm-form-entry-app/dist/openmrs-esm-form-entry-app.js 84.5 kB (+5.83 kB / +7.41%) ↗️
packages/esm-form-entry-app/dist/2.openmrs-esm-form-entry-app.js 46.1 kB (+5.19 kB / +12.69%) ↗️
Unmodified (1) 155 B (0 B / +0%) 👻
Total (4) 1.62 MB (+120 kB / +8.02%) ↗️
@openmrs/esm-generic-patient-widgets-app (+0.19%)
Files new size
packages/esm-generic-patient-widgets-app/dist/701.js 466 kB 👶
packages/esm-generic-patient-widgets-app/dist/926.js 57.9 kB 👶
packages/esm-generic-patient-widgets-app/dist/670.js 37.4 kB 👶
packages/esm-generic-patient-widgets-app/dist/658.js 1.3 MB (-13.8 kB / -1.06%) ↘️
packages/esm-generic-patient-widgets-app/dist/152.js deleted (-37.3 kB)
packages/esm-generic-patient-widgets-app/dist/523.js deleted (-39 kB)
packages/esm-generic-patient-widgets-app/dist/429.js deleted (-465 kB)
packages/esm-generic-patient-widgets-app/dist/217.js 1.51 kB (0 B / +0%) 👻
packages/esm-generic-patient-widgets-app/dist/66.js 324 kB (0 B / +0%) 👻
packages/esm-generic-patient-widgets-app/dist/openmrs-esm-generic-patient-widgets-app.js 9.35 kB (0 B / +0%) 👻
Unmodified (7) 716 kB (0 B / +0%) 👻
Total (17) 2.91 MB (+5.66 kB / +0.19%) ↗️
@openmrs/esm-patient-allergies-app (+0.79%)
Files new size
packages/esm-patient-allergies-app/dist/701.js 465 kB 👶
packages/esm-patient-allergies-app/dist/547.js 237 kB 👶
packages/esm-patient-allergies-app/dist/118.js 49.8 kB 👶
packages/esm-patient-allergies-app/dist/172.js 5.58 kB 👶
packages/esm-patient-allergies-app/dist/584.js 2.29 kB 👶
packages/esm-patient-allergies-app/dist/920.js 3.77 kB (-18 B / -0.47%) ↘️
packages/esm-patient-allergies-app/dist/openmrs-esm-patient-allergies-app.js 12.2 kB (-18 B / -0.15%) ↘️
packages/esm-patient-allergies-app/dist/214.js deleted (-823 B)
packages/esm-patient-allergies-app/dist/151.js deleted (-5.13 kB)
packages/esm-patient-allergies-app/dist/463.js deleted (-35.9 kB)
packages/esm-patient-allergies-app/dist/778.js deleted (-233 kB)
packages/esm-patient-allergies-app/dist/429.js deleted (-465 kB)
packages/esm-patient-allergies-app/dist/104.js 137 kB (0 B / +0%) 👻
packages/esm-patient-allergies-app/dist/415.js 44.6 kB (0 B / +0%) 👻
packages/esm-patient-allergies-app/dist/802.js 141 kB (0 B / +0%) 👻
Unmodified (22) 1.49 MB (0 B / +0%) 👻
Total (37) 2.59 MB (+20.2 kB / +0.79%) ↗️
@openmrs/esm-patient-appointments-app (+0.74%)
Files new size
packages/esm-patient-appointments-app/dist/701.js 466 kB 👶
packages/esm-patient-appointments-app/dist/336.js 26.7 kB 👶
packages/esm-patient-appointments-app/dist/255.js deleted (-12 kB)
packages/esm-patient-appointments-app/dist/429.js deleted (-465 kB)
packages/esm-patient-appointments-app/dist/openmrs-esm-patient-appointments-app.js 10.1 kB (0 B / +0%) 👻
Unmodified (21) 1.56 MB (0 B / +0%) 👻
Total (26) 2.07 MB (+15.2 kB / +0.74%) ↗️
@openmrs/esm-patient-attachments-app (+0.95%)
Files new size
packages/esm-patient-attachments-app/dist/701.js 466 kB 👶
packages/esm-patient-attachments-app/dist/268.js 63.7 kB 👶
packages/esm-patient-attachments-app/dist/989.js deleted (-49 kB)
packages/esm-patient-attachments-app/dist/429.js deleted (-465 kB)
packages/esm-patient-attachments-app/dist/openmrs-esm-patient-attachments-app.js 9.71 kB (0 B / +0%) 👻
Unmodified (16) 1.07 MB (0 B / +0%) 👻
Total (21) 1.61 MB (+15.2 kB / +0.95%) ↗️
@openmrs/esm-patient-banner-app (no impact)
Files new size
Unmodified (15) 992 kB (0 B / +0%) 👻
Total (15) 992 kB (0 B / +0%) 👻
@openmrs/esm-patient-biometrics-app (+0.2%)
Files new size
packages/esm-patient-biometrics-app/dist/701.js 466 kB 👶
packages/esm-patient-biometrics-app/dist/442.js 37.4 kB 👶
packages/esm-patient-biometrics-app/dist/801.js 34.2 kB 👶
packages/esm-patient-biometrics-app/dist/950.js 815 kB (-13.8 kB / -1.67%) ↘️
packages/esm-patient-biometrics-app/dist/833.js deleted (-16 kB)
packages/esm-patient-biometrics-app/dist/152.js deleted (-37.3 kB)
packages/esm-patient-biometrics-app/dist/429.js deleted (-465 kB)
packages/esm-patient-biometrics-app/dist/689.js 284 kB (0 B / +0%) 👻
packages/esm-patient-biometrics-app/dist/891.js 2.49 kB (0 B / +0%) 👻
packages/esm-patient-biometrics-app/dist/openmrs-esm-patient-biometrics-app.js 10.6 kB (0 B / +0%) 👻
Unmodified (14) 887 kB (0 B / +0%) 👻
Total (24) 2.54 MB (+4.98 kB / +0.2%) ↗️
@openmrs/esm-patient-chart-app (+0.34%)
Files new size
packages/esm-patient-chart-app/dist/701.js 465 kB 👶
packages/esm-patient-chart-app/dist/75.js 282 kB 👶
packages/esm-patient-chart-app/dist/858.js 155 kB 👶
packages/esm-patient-chart-app/dist/352.js 43 kB 👶
packages/esm-patient-chart-app/dist/671.js 11.2 kB 👶
packages/esm-patient-chart-app/dist/373.js 11.1 kB 👶
packages/esm-patient-chart-app/dist/574.js 2.64 kB (+62 B / +2.4%) ↗️
packages/esm-patient-chart-app/dist/openmrs-esm-patient-chart-app.js 18.1 kB (-1.04 kB / -5.45%) ↘️
packages/esm-patient-chart-app/dist/920.js 9.28 kB (-1.14 kB / -10.97%) ↘️
packages/esm-patient-chart-app/dist/614.js deleted (-6.84 kB)
packages/esm-patient-chart-app/dist/857.js deleted (-9.71 kB)
packages/esm-patient-chart-app/dist/440.js deleted (-32.4 kB)
packages/esm-patient-chart-app/dist/140.js deleted (-159 kB)
packages/esm-patient-chart-app/dist/653.js deleted (-280 kB)
packages/esm-patient-chart-app/dist/429.js deleted (-465 kB)
packages/esm-patient-chart-app/dist/202.js 167 kB (0 B / +0%) 👻
Unmodified (30) 2.42 MB (0 B / +0%) 👻
Total (46) 3.58 MB (+12.1 kB / +0.34%) ↗️
@openmrs/esm-patient-clinical-view-app (+0.52%)
Files new size
packages/esm-patient-clinical-view-app/dist/701.js 466 kB 👶
packages/esm-patient-clinical-view-app/dist/620.js 53.2 kB 👶
packages/esm-patient-clinical-view-app/dist/987.js 25.2 kB 👶
packages/esm-patient-clinical-view-app/dist/68.js 12 kB 👶
packages/esm-patient-clinical-view-app/dist/openmrs-esm-patient-clinical-view-app.js 9.82 kB (+32 B / +0.33%) ↗️
packages/esm-patient-clinical-view-app/dist/920.js 1.94 kB (+8 B / +0.41%) ↗️
packages/esm-patient-clinical-view-app/dist/667.js deleted (-36.1 kB)
packages/esm-patient-clinical-view-app/dist/612.js deleted (-47.4 kB)
packages/esm-patient-clinical-view-app/dist/429.js deleted (-465 kB)
packages/esm-patient-clinical-view-app/dist/200.js 37 kB (0 B / +0%) 👻
Unmodified (12) 809 kB (0 B / +0%) 👻
Total (22) 1.41 MB (+7.38 kB / +0.52%) ↗️
@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}
@openmrs/esm-patient-conditions-app (+0.8%)
Files new size
packages/esm-patient-conditions-app/dist/701.js 466 kB 👶
packages/esm-patient-conditions-app/dist/756.js 119 kB 👶
packages/esm-patient-conditions-app/dist/926.js 47.4 kB 👶
packages/esm-patient-conditions-app/dist/901.js 29.7 kB 👶
packages/esm-patient-conditions-app/dist/26.js 23.3 kB 👶
packages/esm-patient-conditions-app/dist/655.js 1.77 kB (-1 B / -0.06%) ↘️
packages/esm-patient-conditions-app/dist/openmrs-esm-patient-conditions-app.js 10.1 kB (-4 B / -0.04%) ↘️
packages/esm-patient-conditions-app/dist/975.js deleted (-15.4 kB)
packages/esm-patient-conditions-app/dist/809.js deleted (-22.2 kB)
packages/esm-patient-conditions-app/dist/360.js deleted (-47.1 kB)
packages/esm-patient-conditions-app/dist/529.js deleted (-120 kB)
packages/esm-patient-conditions-app/dist/429.js deleted (-465 kB)
packages/esm-patient-conditions-app/dist/974.js 142 kB (0 B / +0%) 👻
Unmodified (17) 1.08 MB (0 B / +0%) 👻
Total (30) 1.92 MB (+15.2 kB / +0.8%) ↗️
@openmrs/esm-patient-forms-app (+0.83%)
Files new size
packages/esm-patient-forms-app/dist/701.js 465 kB 👶
packages/esm-patient-forms-app/dist/337.js 352 kB 👶
packages/esm-patient-forms-app/dist/377.js 238 kB 👶
packages/esm-patient-forms-app/dist/44.js 39.3 kB 👶
packages/esm-patient-forms-app/dist/277.js 31.7 kB 👶
packages/esm-patient-forms-app/dist/758.js 17.4 kB 👶
packages/esm-patient-forms-app/dist/647.js 736 B (+222 B / +43.19%) ↗️
packages/esm-patient-forms-app/dist/902.js 750 B (+222 B / +42.05%) ↗️
packages/esm-patient-forms-app/dist/489.js 4.73 kB (+111 B / +2.4%) ↗️
packages/esm-patient-forms-app/dist/openmrs-esm-patient-forms-app.js 12.8 kB (+108 B / +0.85%) ↗️
packages/esm-patient-forms-app/dist/88.js 44.1 kB (+19 B / +0.04%) ↗️
packages/esm-patient-forms-app/dist/574.js 939 B (-54 B / -5.44%) ↘️
packages/esm-patient-forms-app/dist/369.js 36 kB (-1.38 kB / -3.68%) ↘️
packages/esm-patient-forms-app/dist/848.js deleted (-16.5 kB)
packages/esm-patient-forms-app/dist/698.js deleted (-16.8 kB)
packages/esm-patient-forms-app/dist/870.js deleted (-37.8 kB)
packages/esm-patient-forms-app/dist/602.js deleted (-240 kB)
packages/esm-patient-forms-app/dist/324.js deleted (-352 kB)
packages/esm-patient-forms-app/dist/429.js deleted (-465 kB)
Unmodified (11) 745 kB (0 B / +0%) 👻
Total (30) 1.99 MB (+16.3 kB / +0.83%) ↗️
@openmrs/esm-patient-immunizations-app (+0.12%)
Files new size
packages/esm-patient-immunizations-app/dist/701.js 466 kB 👶
packages/esm-patient-immunizations-app/dist/183.js 55.2 kB 👶
packages/esm-patient-immunizations-app/dist/849.js 33.2 kB 👶
packages/esm-patient-immunizations-app/dist/185.js 5.42 kB 👶
packages/esm-patient-immunizations-app/dist/943.js deleted (-22 kB)
packages/esm-patient-immunizations-app/dist/684.js deleted (-32.5 kB)
packages/esm-patient-immunizations-app/dist/870.js deleted (-37.8 kB)
packages/esm-patient-immunizations-app/dist/429.js deleted (-465 kB)
packages/esm-patient-immunizations-app/dist/217.js 49.3 kB (0 B / +0%) 👻
packages/esm-patient-immunizations-app/dist/259.js 2.96 kB (0 B / +0%) 👻
packages/esm-patient-immunizations-app/dist/477.js 47.1 kB (0 B / +0%) 👻
packages/esm-patient-immunizations-app/dist/920.js 47.3 kB (0 B / +0%) 👻
packages/esm-patient-immunizations-app/dist/openmrs-esm-patient-immunizations-app.js 10.9 kB (0 B / +0%) 👻
Unmodified (12) 1.09 MB (0 B / +0%) 👻
Total (25) 1.81 MB (+2.1 kB / +0.12%) ↗️
@openmrs/esm-patient-medications-app (+0.02%)
Files new size
packages/esm-patient-medications-app/dist/701.js 466 kB 👶
packages/esm-patient-medications-app/dist/976.js 188 kB 👶
packages/esm-patient-medications-app/dist/112.js 51.7 kB 👶
packages/esm-patient-medications-app/dist/574.js 3.65 kB (+210 B / +6.1%) ↗️
packages/esm-patient-medications-app/dist/151.js 251 kB (-1.57 kB / -0.62%) ↘️
packages/esm-patient-medications-app/dist/939.js deleted (-37.4 kB)
packages/esm-patient-medications-app/dist/636.js deleted (-38.5 kB)
packages/esm-patient-medications-app/dist/861.js 40.1 kB (-162 kB / -80.21%) ↘️
packages/esm-patient-medications-app/dist/429.js deleted (-465 kB)
packages/esm-patient-medications-app/dist/655.js 1.79 kB (0 B / +0%) 👻
packages/esm-patient-medications-app/dist/932.js 134 kB (0 B / +0%) 👻
packages/esm-patient-medications-app/dist/openmrs-esm-patient-medications-app.js 9.82 kB (0 B / +0%) 👻
Unmodified (10) 1.62 MB (0 B / +0%) 👻
Total (22) 2.77 MB (+595 B / +0.02%) ↗️
@openmrs/esm-patient-notes-app (+0.78%)
Files new size
packages/esm-patient-notes-app/dist/701.js 465 kB 👶
packages/esm-patient-notes-app/dist/722.js 123 kB 👶
packages/esm-patient-notes-app/dist/566.js 29.5 kB 👶
packages/esm-patient-notes-app/dist/26.js 23.3 kB 👶
packages/esm-patient-notes-app/dist/openmrs-esm-patient-notes-app.js 10.5 kB (-2 B / -0.02%) ↘️
packages/esm-patient-notes-app/dist/975.js deleted (-15.4 kB)
packages/esm-patient-notes-app/dist/809.js deleted (-22.1 kB)
packages/esm-patient-notes-app/dist/66.js deleted (-123 kB)
packages/esm-patient-notes-app/dist/429.js deleted (-465 kB)
packages/esm-patient-notes-app/dist/411.js 2.43 kB (0 B / +0%) 👻
packages/esm-patient-notes-app/dist/645.js 147 kB (0 B / +0%) 👻
Unmodified (17) 1.15 MB (0 B / +0%) 👻
Total (28) 1.95 MB (+15 kB / +0.78%) ↗️
@openmrs/esm-patient-programs-app (+0.15%)
Files new size
packages/esm-patient-programs-app/dist/701.js 465 kB 👶
packages/esm-patient-programs-app/dist/550.js 263 kB 👶
packages/esm-patient-programs-app/dist/538.js 118 kB 👶
packages/esm-patient-programs-app/dist/131.js 58.5 kB 👶
packages/esm-patient-programs-app/dist/655.js 1.69 kB (-25 B / -1.46%) ↘️
packages/esm-patient-programs-app/dist/openmrs-esm-patient-programs-app.js 9.71 kB (-33 B / -0.34%) ↘️
packages/esm-patient-programs-app/dist/754.js deleted (-19.2 kB)
packages/esm-patient-programs-app/dist/158.js deleted (-41.1 kB)
packages/esm-patient-programs-app/dist/364.js deleted (-116 kB)
packages/esm-patient-programs-app/dist/78.js deleted (-261 kB)
packages/esm-patient-programs-app/dist/429.js deleted (-465 kB)
Unmodified (14) 992 kB (0 B / +0%) 👻
Total (25) 1.91 MB (+2.8 kB / +0.15%) ↗️
@openmrs/esm-patient-test-results-app (+0.1%)
Files new size
packages/esm-patient-test-results-app/dist/701.js 466 kB 👶
packages/esm-patient-test-results-app/dist/214.js 46.9 kB 👶
packages/esm-patient-test-results-app/dist/327.js 35.5 kB 👶
packages/esm-patient-test-results-app/dist/156.js 12.7 kB 👶
packages/esm-patient-test-results-app/dist/openmrs-esm-patient-test-results-app.js 11 kB (+36 B / +0.33%) ↗️
packages/esm-patient-test-results-app/dist/920.js 2.82 kB (+9 B / +0.32%) ↗️
packages/esm-patient-test-results-app/dist/882.js 256 kB (-6.03 kB / -2.3%) ↘️
packages/esm-patient-test-results-app/dist/621.js 1.48 MB (-9.51 kB / -0.64%) ↘️
packages/esm-patient-test-results-app/dist/576.js deleted (-29.5 kB)
packages/esm-patient-test-results-app/dist/300.js deleted (-46.9 kB)
packages/esm-patient-test-results-app/dist/429.js deleted (-465 kB)
Unmodified (20) 1.61 MB (0 B / +0%) 👻
Total (31) 3.92 MB (+3.72 kB / +0.1%) ↗️
@openmrs/esm-patient-vitals-app (+0.14%)
Files new size
packages/esm-patient-vitals-app/dist/701.js 465 kB 👶
packages/esm-patient-vitals-app/dist/869.js 36 kB 👶
packages/esm-patient-vitals-app/dist/104.js 20.8 kB 👶
packages/esm-patient-vitals-app/dist/659.js deleted (-2.59 kB)
packages/esm-patient-vitals-app/dist/234.js 1.26 MB (-13.8 kB / -1.09%) ↘️
packages/esm-patient-vitals-app/dist/463.js deleted (-35.9 kB)
packages/esm-patient-vitals-app/dist/429.js deleted (-465 kB)
packages/esm-patient-vitals-app/dist/241.js 286 kB (0 B / +0%) 👻
packages/esm-patient-vitals-app/dist/486.js 3.37 kB (0 B / +0%) 👻
packages/esm-patient-vitals-app/dist/openmrs-esm-patient-vitals-app.js 11.4 kB (0 B / +0%) 👻
Unmodified (18) 1.37 MB (0 B / +0%) 👻
Total (28) 3.45 MB (+4.98 kB / +0.14%) ↗️
Generated by @jsenv/file-size-impact during Report bundle size#1956180800 on 946695b

@donaldkibet donaldkibet force-pushed the feature/recommended-visits branch 2 times, most recently from 0a58721 to c6f4cb4 Compare March 7, 2022 12:46
@donaldkibet donaldkibet force-pushed the feature/recommended-visits branch from c6f4cb4 to 6c1254d Compare March 7, 2022 19:00
@donaldkibet donaldkibet force-pushed the feature/recommended-visits branch from 6c1254d to 946695b Compare March 9, 2022 08:38
@donaldkibet donaldkibet merged commit 67b85a7 into master Mar 9, 2022
@donaldkibet donaldkibet deleted the feature/recommended-visits branch April 23, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants