Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Timeline Results Grouping O3-1060 #591

Merged
merged 14 commits into from
Mar 11, 2022
Merged

Conversation

ZacButko
Copy link
Contributor

@ZacButko ZacButko commented Mar 3, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

Work in progress draft PR that extends FilterSet context to support Lowest Parent which is needed to make timeline groupings. Some progress has been made to the timeline grouping UI, although there is still more work to be done until this is finished

New progress:

  • Style changes to filter (indent first node, undo 0th node bold, remove border from leaves, apply disable to no data)
  • Remove tests with no data from timeline
  • Disable checkboxes in filter for tests with no data
  • "nothing checked means everything is checked"
  • Check/Uncheck test only affect displaying that test in that parent. Other parents with same test will not be affected
  • Timeline tests are grouped based on their lowest common parent
  • Maximize / Minimize Timeline Button
  • Grouped title doesn't stretch full width
  • Separate groups don't scroll horizontally together
  • Group head (datetimes) are not sticky to top of page
  • Configuration
  • Multiple /obstree requests

Not working:

  • Include Panel Data
  • Loading of Trendline
  • Tablet view, floating action button for filter
  • List of filters at top bar
  • Modular extension
  • Unit Tests
  • Deduplicate code

Screenshots

Related Issue

Ticket -> https://issues.openmrs.org/browse/O3-1060
Concept -> https://app.zeplin.io/project/60d59321e8100b0324762e05/screen/621e53c282619babb9a9d6b5

Other

This is just a draft PR. Feel free to take a look and suggest changes 🙂 . More better changes, + code cleanup refactor coming soon.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022


Error: Error while trying to collect info after merging zabutko/filter-timeline into master.

Error: Command failed: git merge FETCH_HEAD --allow-unrelated-histories

    at ChildProcess.exithandler (node:child_process:397:12)
    at ChildProcess.emit (node:events:394:28)
    at maybeClose (node:internal/child_process:1067:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)

Generated by @jsenv/file-size-impact during Report bundle size#1962394212 on 47be92a

@ZacButko ZacButko changed the title (feat) Timeline Results Grouping DRAFT O3-1060 (feat) Timeline Results Grouping O3-1060 Mar 11, 2022
@ZacButko ZacButko marked this pull request as ready for review March 11, 2022 17:26
Copy link
Member

@jonathandick jonathandick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ZacButko! Very glad to see this work moving forward.

@jonathandick jonathandick merged commit d629a77 into master Mar 11, 2022
@ibacher ibacher deleted the zabutko/filter-timeline branch January 16, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants