-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Timeline Results Grouping O3-1060 #591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error: Error while trying to collect info after merging zabutko/filter-timeline into master. Error: Command failed: git merge FETCH_HEAD --allow-unrelated-histories at ChildProcess.exithandler (node:child_process:397:12) at ChildProcess.emit (node:events:394:28) at maybeClose (node:internal/child_process:1067:16) at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5) Generated by @jsenv/file-size-impact during Report bundle size#1962394212 on 47be92a |
ZacButko
changed the title
(feat) Timeline Results Grouping DRAFT O3-1060
(feat) Timeline Results Grouping O3-1060
Mar 11, 2022
ZacButko
requested review from
brandones,
denniskigen,
donaldkibet and
jonathandick
March 11, 2022 17:27
jonathandick
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ZacButko! Very glad to see this work moving forward.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Work in progress draft PR that extends FilterSet context to support Lowest Parent which is needed to make timeline groupings. Some progress has been made to the timeline grouping UI, although there is still more work to be done until this is finished
New progress:
Not working:
Screenshots
Related Issue
Ticket -> https://issues.openmrs.org/browse/O3-1060
Concept -> https://app.zeplin.io/project/60d59321e8100b0324762e05/screen/621e53c282619babb9a9d6b5
Other
This is just a draft PR. Feel free to take a look and suggest changes 🙂 . More better changes, + code cleanup refactor coming soon.