Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O3-928: (Solved) "Renew" action disapeared on past medications actions #597

Merged
merged 3 commits into from
Mar 9, 2022
Merged

O3-928: (Solved) "Renew" action disapeared on past medications actions #597

merged 3 commits into from
Mar 9, 2022

Conversation

vasharma05
Copy link
Member

@vasharma05 vasharma05 commented Mar 8, 2022 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

  1. The reorder button was disabled on the past order, which is re-enabled.
  2. Along with that, I have assigned different translation keys to Active medications and Past Medications on the basis of their casing, as in to clear the below warnings.
    image

Screenshots

image

Related Issue

https://issues.openmrs.org/browse/O3-928

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

File size impact

Merging O3-928-order-fix into master impact files as follow:

@openmrs/esm-form-entry-app (+8.02%)
Files new size
packages/esm-form-entry-app/dist/1.openmrs-esm-form-entry-app.js 1.48 MB (+109 kB / +7.92%) ↗️
packages/esm-form-entry-app/dist/openmrs-esm-form-entry-app.js 84.5 kB (+5.83 kB / +7.41%) ↗️
packages/esm-form-entry-app/dist/2.openmrs-esm-form-entry-app.js 46.1 kB (+5.19 kB / +12.69%) ↗️
Unmodified (1) 155 B (0 B / +0%) 👻
Total (4) 1.62 MB (+120 kB / +8.02%) ↗️
@openmrs/esm-generic-patient-widgets-app (no impact)
Files new size
Unmodified (14) 2.9 MB (0 B / +0%) 👻
Total (14) 2.9 MB (0 B / +0%) 👻
@openmrs/esm-patient-allergies-app (no impact)
Files new size
Unmodified (32) 2.57 MB (0 B / +0%) 👻
Total (32) 2.57 MB (0 B / +0%) 👻
@openmrs/esm-patient-appointments-app (no impact)
Files new size
Unmodified (24) 2.05 MB (0 B / +0%) 👻
Total (24) 2.05 MB (0 B / +0%) 👻
@openmrs/esm-patient-attachments-app (no impact)
Files new size
Unmodified (19) 1.6 MB (0 B / +0%) 👻
Total (19) 1.6 MB (0 B / +0%) 👻
@openmrs/esm-patient-banner-app (no impact)
Files new size
Unmodified (15) 992 kB (0 B / +0%) 👻
Total (15) 992 kB (0 B / +0%) 👻
@openmrs/esm-patient-biometrics-app (no impact)
Files new size
Unmodified (21) 2.53 MB (0 B / +0%) 👻
Total (21) 2.53 MB (0 B / +0%) 👻
@openmrs/esm-patient-chart-app (no impact)
Files new size
Unmodified (40) 3.57 MB (0 B / +0%) 👻
Total (40) 3.57 MB (0 B / +0%) 👻
@openmrs/esm-patient-clinical-view-app (no impact)
Files new size
Unmodified (18) 1.41 MB (0 B / +0%) 👻
Total (18) 1.41 MB (0 B / +0%) 👻
@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}
@openmrs/esm-patient-conditions-app (no impact)
Files new size
Unmodified (25) 1.91 MB (0 B / +0%) 👻
Total (25) 1.91 MB (0 B / +0%) 👻
@openmrs/esm-patient-forms-app (no impact)
Files new size
Unmodified (24) 1.97 MB (0 B / +0%) 👻
Total (24) 1.97 MB (0 B / +0%) 👻
@openmrs/esm-patient-immunizations-app (no impact)
Files new size
Unmodified (21) 1.81 MB (0 B / +0%) 👻
Total (21) 1.81 MB (0 B / +0%) 👻
@openmrs/esm-patient-medications-app (+0.02%)
Files new size
packages/esm-patient-medications-app/dist/574.js 3.44 kB (+220 B / +6.83%) ↗️
packages/esm-patient-medications-app/dist/932.js 134 kB (+110 B / +0.08%) ↗️
packages/esm-patient-medications-app/dist/842.js 128 kB (+64 B / +0.05%) ↗️
packages/esm-patient-medications-app/dist/660.js 1.1 kB (+32 B / +3%) ↗️
packages/esm-patient-medications-app/dist/763.js 773 kB (+32 B / +0%) ↗️
Unmodified (14) 1.73 MB (0 B / +0%) 👻
Total (19) 2.77 MB (+458 B / +0.02%) ↗️
@openmrs/esm-patient-notes-app (no impact)
Files new size
Unmodified (24) 1.94 MB (0 B / +0%) 👻
Total (24) 1.94 MB (0 B / +0%) 👻
@openmrs/esm-patient-programs-app (no impact)
Files new size
Unmodified (21) 1.91 MB (0 B / +0%) 👻
Total (21) 1.91 MB (0 B / +0%) 👻
@openmrs/esm-patient-test-results-app (no impact)
Files new size
Unmodified (27) 3.92 MB (0 B / +0%) 👻
Total (27) 3.92 MB (0 B / +0%) 👻
@openmrs/esm-patient-vitals-app (no impact)
Files new size
Unmodified (25) 3.44 MB (0 B / +0%) 👻
Total (25) 3.44 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#1951534553 on ce3c8b8

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

File size impact

Merging O3-928-order-fix into master impact files as follow:

@openmrs/esm-form-entry-app (+8.02%)
Files new size
packages/esm-form-entry-app/dist/1.openmrs-esm-form-entry-app.js 1.48 MB (+109 kB / +7.92%) ↗️
packages/esm-form-entry-app/dist/openmrs-esm-form-entry-app.js 84.5 kB (+5.83 kB / +7.41%) ↗️
packages/esm-form-entry-app/dist/2.openmrs-esm-form-entry-app.js 46.1 kB (+5.19 kB / +12.69%) ↗️
Unmodified (1) 155 B (0 B / +0%) 👻
Total (4) 1.62 MB (+120 kB / +8.02%) ↗️
@openmrs/esm-generic-patient-widgets-app (no impact)
Files new size
Unmodified (14) 2.9 MB (0 B / +0%) 👻
Total (14) 2.9 MB (0 B / +0%) 👻
@openmrs/esm-patient-allergies-app (no impact)
Files new size
Unmodified (32) 2.57 MB (0 B / +0%) 👻
Total (32) 2.57 MB (0 B / +0%) 👻
@openmrs/esm-patient-appointments-app (no impact)
Files new size
Unmodified (24) 2.05 MB (0 B / +0%) 👻
Total (24) 2.05 MB (0 B / +0%) 👻
@openmrs/esm-patient-attachments-app (no impact)
Files new size
Unmodified (19) 1.6 MB (0 B / +0%) 👻
Total (19) 1.6 MB (0 B / +0%) 👻
@openmrs/esm-patient-banner-app (no impact)
Files new size
Unmodified (15) 992 kB (0 B / +0%) 👻
Total (15) 992 kB (0 B / +0%) 👻
@openmrs/esm-patient-biometrics-app (no impact)
Files new size
Unmodified (21) 2.53 MB (0 B / +0%) 👻
Total (21) 2.53 MB (0 B / +0%) 👻
@openmrs/esm-patient-chart-app (no impact)
Files new size
Unmodified (40) 3.57 MB (0 B / +0%) 👻
Total (40) 3.57 MB (0 B / +0%) 👻
@openmrs/esm-patient-clinical-view-app (no impact)
Files new size
Unmodified (18) 1.41 MB (0 B / +0%) 👻
Total (18) 1.41 MB (0 B / +0%) 👻
@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}
@openmrs/esm-patient-conditions-app (no impact)
Files new size
Unmodified (25) 1.91 MB (0 B / +0%) 👻
Total (25) 1.91 MB (0 B / +0%) 👻
@openmrs/esm-patient-forms-app (no impact)
Files new size
Unmodified (24) 1.97 MB (0 B / +0%) 👻
Total (24) 1.97 MB (0 B / +0%) 👻
@openmrs/esm-patient-immunizations-app (no impact)
Files new size
Unmodified (21) 1.81 MB (0 B / +0%) 👻
Total (21) 1.81 MB (0 B / +0%) 👻
@openmrs/esm-patient-medications-app (+0.02%)
Files new size
packages/esm-patient-medications-app/dist/574.js 3.44 kB (+220 B / +6.83%) ↗️
packages/esm-patient-medications-app/dist/932.js 134 kB (+110 B / +0.08%) ↗️
packages/esm-patient-medications-app/dist/842.js 128 kB (+64 B / +0.05%) ↗️
packages/esm-patient-medications-app/dist/660.js 1.1 kB (+32 B / +3%) ↗️
packages/esm-patient-medications-app/dist/763.js 773 kB (+32 B / +0%) ↗️
Unmodified (14) 1.73 MB (0 B / +0%) 👻
Total (19) 2.77 MB (+458 B / +0.02%) ↗️
@openmrs/esm-patient-notes-app (no impact)
Files new size
Unmodified (24) 1.94 MB (0 B / +0%) 👻
Total (24) 1.94 MB (0 B / +0%) 👻
@openmrs/esm-patient-programs-app (no impact)
Files new size
Unmodified (21) 1.91 MB (0 B / +0%) 👻
Total (21) 1.91 MB (0 B / +0%) 👻
@openmrs/esm-patient-test-results-app (no impact)
Files new size
Unmodified (27) 3.92 MB (0 B / +0%) 👻
Total (27) 3.92 MB (0 B / +0%) 👻
@openmrs/esm-patient-vitals-app (no impact)
Files new size
Unmodified (25) 3.44 MB (0 B / +0%) 👻
Total (25) 3.44 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#1951544471 on ce3c8b8

ZacButko
ZacButko approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@ZacButko ZacButko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@vasharma05 vasharma05 merged commit f94ef90 into openmrs:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacButko ZacButko ZacButko approved these changes

@brandones brandones Awaiting requested review from brandones

@denniskigen denniskigen Awaiting requested review from denniskigen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasharma05 @ZacButko