Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Use cross-env to pass TZ=UTC environment variable to jest #599

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

brandones
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

yarn test was not working on Powershell because Powershell doesn't understand POSIX syntax for environment variables. cross-env makes it work in any shell.

@brandones brandones requested a review from vasharma05 March 9, 2022 18:14
@brandones brandones changed the title Use cross-env to pass TZ=UTC environment variable to jest (chore) Use cross-env to pass TZ=UTC environment variable to jest Mar 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

File size impact

Merging cross-env into master impact files as follow:

@openmrs/esm-form-entry-app (+8.02%)
Files new size
packages/esm-form-entry-app/dist/1.openmrs-esm-form-entry-app.js 1.48 MB (+109 kB / +7.92%) ↗️
packages/esm-form-entry-app/dist/openmrs-esm-form-entry-app.js 84.5 kB (+5.83 kB / +7.41%) ↗️
packages/esm-form-entry-app/dist/2.openmrs-esm-form-entry-app.js 46.1 kB (+5.19 kB / +12.69%) ↗️
Unmodified (1) 155 B (0 B / +0%) 👻
Total (4) 1.62 MB (+120 kB / +8.02%) ↗️
@openmrs/esm-generic-patient-widgets-app (no impact)
Files new size
Unmodified (14) 2.91 MB (0 B / +0%) 👻
Total (14) 2.91 MB (0 B / +0%) 👻
@openmrs/esm-patient-allergies-app (no impact)
Files new size
Unmodified (32) 2.59 MB (0 B / +0%) 👻
Total (32) 2.59 MB (0 B / +0%) 👻
@openmrs/esm-patient-appointments-app (no impact)
Files new size
Unmodified (24) 2.07 MB (0 B / +0%) 👻
Total (24) 2.07 MB (0 B / +0%) 👻
@openmrs/esm-patient-attachments-app (no impact)
Files new size
Unmodified (19) 1.61 MB (0 B / +0%) 👻
Total (19) 1.61 MB (0 B / +0%) 👻
@openmrs/esm-patient-banner-app (no impact)
Files new size
Unmodified (15) 992 kB (0 B / +0%) 👻
Total (15) 992 kB (0 B / +0%) 👻
@openmrs/esm-patient-biometrics-app (no impact)
Files new size
Unmodified (21) 2.54 MB (0 B / +0%) 👻
Total (21) 2.54 MB (0 B / +0%) 👻
@openmrs/esm-patient-chart-app (no impact)
Files new size
Unmodified (40) 3.58 MB (0 B / +0%) 👻
Total (40) 3.58 MB (0 B / +0%) 👻
@openmrs/esm-patient-clinical-view-app (no impact)
Files new size
Unmodified (19) 1.41 MB (0 B / +0%) 👻
Total (19) 1.41 MB (0 B / +0%) 👻
@openmrs/esm-patient-common-lib (no impact)

No file in @openmrs/esm-patient-common-lib group (see config below).

{
  "./packages/esm-patient-common-lib/dist/*.js": true,
  "./packages/esm-patient-common-lib/dist/*.css": true,
  "./packages/esm-patient-common-lib/dist/*.map": false,
  "./packages/esm-patient-common-lib/dist/*.txt": false,
  "./packages/esm-patient-common-lib/dist/*.json": false
}
@openmrs/esm-patient-conditions-app (no impact)
Files new size
Unmodified (25) 1.92 MB (0 B / +0%) 👻
Total (25) 1.92 MB (0 B / +0%) 👻
@openmrs/esm-patient-forms-app (no impact)
Files new size
Unmodified (24) 1.99 MB (0 B / +0%) 👻
Total (24) 1.99 MB (0 B / +0%) 👻
@openmrs/esm-patient-immunizations-app (no impact)
Files new size
Unmodified (21) 1.81 MB (0 B / +0%) 👻
Total (21) 1.81 MB (0 B / +0%) 👻
@openmrs/esm-patient-medications-app (no impact)
Files new size
Unmodified (19) 2.77 MB (0 B / +0%) 👻
Total (19) 2.77 MB (0 B / +0%) 👻
@openmrs/esm-patient-notes-app (no impact)
Files new size
Unmodified (24) 1.95 MB (0 B / +0%) 👻
Total (24) 1.95 MB (0 B / +0%) 👻
@openmrs/esm-patient-programs-app (no impact)
Files new size
Unmodified (20) 1.91 MB (0 B / +0%) 👻
Total (20) 1.91 MB (0 B / +0%) 👻
@openmrs/esm-patient-test-results-app (no impact)
Files new size
Unmodified (28) 3.92 MB (0 B / +0%) 👻
Total (28) 3.92 MB (0 B / +0%) 👻
@openmrs/esm-patient-vitals-app (no impact)
Files new size
Unmodified (25) 3.45 MB (0 B / +0%) 👻
Total (25) 3.45 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#1958959987 on 53fdd1d

@brandones brandones requested a review from ZacButko March 9, 2022 19:19
@vasharma05
Copy link
Member

Hey @brandones!
I visited the https://www.npmjs.com/package/cross-env, and found a warning there:

NOTICE: cross-env still works well, but is in maintenance mode. No new features will be added, only serious and common-case bugs will be fixed, and it will only be kept up-to-date with Node.js over time.

Will this be an issue in the future?
Other than this, I read about the cross-env and it's a viable solution for the same.

@brandones
Copy link
Contributor Author

Yep, it would be bad if it was unmaintained, but it is "in maintenance mode." It's an extremely simple utility and I don't imagine we'll be needing new features from it :)

@brandones brandones merged commit 77635e0 into master Mar 9, 2022
@brandones brandones deleted the cross-env branch March 9, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants