(test) Assert appearance and disappearance of Add and Edit buttons
#603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size impactMerging testClinicalOverview into master impact files as follow: @openmrs/esm-form-entry-app (+8.02%)
@openmrs/esm-generic-patient-widgets-app (no impact)
@openmrs/esm-patient-allergies-app (no impact)
@openmrs/esm-patient-appointments-app (no impact)
@openmrs/esm-patient-attachments-app (no impact)
@openmrs/esm-patient-banner-app (no impact)
@openmrs/esm-patient-biometrics-app (no impact)
@openmrs/esm-patient-chart-app (no impact)
@openmrs/esm-patient-clinical-view-app (no impact)
@openmrs/esm-patient-common-lib (no impact)No file in @openmrs/esm-patient-common-lib group (see config below). {
"./packages/esm-patient-common-lib/dist/*.js": true,
"./packages/esm-patient-common-lib/dist/*.css": true,
"./packages/esm-patient-common-lib/dist/*.map": false,
"./packages/esm-patient-common-lib/dist/*.txt": false,
"./packages/esm-patient-common-lib/dist/*.json": false
}@openmrs/esm-patient-conditions-app (no impact)
@openmrs/esm-patient-forms-app (no impact)
@openmrs/esm-patient-immunizations-app (no impact)
@openmrs/esm-patient-medications-app (no impact)
@openmrs/esm-patient-notes-app (no impact)
@openmrs/esm-patient-programs-app (no impact)
@openmrs/esm-patient-test-results-app (no impact)
@openmrs/esm-patient-vitals-app (no impact)
|
denniskigen
reviewed
Mar 14, 2022
| @@ -4,6 +4,7 @@ import userEvent from '@testing-library/user-event'; | |||
| import { launchPatientWorkspace } from '@openmrs/esm-patient-common-lib'; | |||
| import { mockPatient } from '../../../../__mocks__/patient.mock'; | |||
| import ClinicalViewOverview from './clinical-view-overview.component'; | |||
| import { ExtensionSlot } from '@openmrs/esm-framework'; | |||
There was a problem hiding this comment.
If what you're asserting is the appearance of the Edit View button and the disappearance of the Add View button when the user clicks on a clinical view, you do not need this import.
| @@ -44,6 +45,9 @@ describe('ClinicalViewOverview: ', () => { | |||
| mockClinicalViews.map((clinicalView) => | |||
| expect(screen.getByRole('tab', { name: clinicalView.slot })).toBeInTheDocument(), | |||
| ); | |||
| const breadCrampCheck = screen.getByRole('tab', { name: 'Breadcrumbs' }); | |||
There was a problem hiding this comment.
If the assertions you're making are the ones listed above, a preferable way to do this would be to check for the appearance and absence of the two buttons in each case. Like:
renderClinicalViewOverview();
expect(screen.getByRole('tablist')).toBeInTheDocument();
expect(screen.getByRole('button', { name: /Add view/i })).toBeInTheDocument();
expect(screen.queryByRole('button', { name: /Edit view/i })).not.toBeInTheDocument();
mockClinicalViews.map((clinicalView) =>
expect(screen.getByRole('tab', { name: clinicalView.slot })).toBeInTheDocument(),
);
userEvent.click(screen.getByRole('tab', { name: /breadcrumbs/i }));
expect(screen.getByRole('button', { name: /Edit view/i })).toBeInTheDocument();
expect(screen.queryByRole('button', { name: /Add view/i })).not.toBeInTheDocument();There was a problem hiding this comment.
@denniskigen thanks for the review. issue has been worked on
denniskigen
changed the title
Add and Edit buttons
|
Thanks, @nanfuka! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Related Issue
Other