03 1168: Add ability to cancel (void) active visit
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size impactMerging 03-1168 into master impact files as follow: @openmrs/esm-form-entry-app (+8.03%)
@openmrs/esm-generic-patient-widgets-app (+0%)
@openmrs/esm-patient-allergies-app (+0%)
@openmrs/esm-patient-appointments-app (+0%)
@openmrs/esm-patient-attachments-app (+0%)
@openmrs/esm-patient-banner-app (no impact)
@openmrs/esm-patient-biometrics-app (+0%)
@openmrs/esm-patient-chart-app (+3.68%)
@openmrs/esm-patient-clinical-view-app (+0%)
@openmrs/esm-patient-common-lib (no impact)No file in @openmrs/esm-patient-common-lib group (see config below). {
"./packages/esm-patient-common-lib/dist/*.js": true,
"./packages/esm-patient-common-lib/dist/*.css": true,
"./packages/esm-patient-common-lib/dist/*.map": false,
"./packages/esm-patient-common-lib/dist/*.txt": false,
"./packages/esm-patient-common-lib/dist/*.json": false
}@openmrs/esm-patient-conditions-app (+0%)
@openmrs/esm-patient-forms-app (+0%)
@openmrs/esm-patient-immunizations-app (+0%)
@openmrs/esm-patient-medications-app (+0%)
@openmrs/esm-patient-notes-app (+0%)
@openmrs/esm-patient-programs-app (+0%)
@openmrs/esm-patient-test-results-app (+0%)
@openmrs/esm-patient-vitals-app (+0%)
|
|
@donaldkibet won't you need to write tests for the added code? |
brandones
reviewed
Mar 16, 2022
packages/esm-patient-chart-app/src/actions-buttons/cancel-visit.component.tsx
Show resolved
Hide resolved
brandones
reviewed
Mar 16, 2022
packages/esm-patient-chart-app/src/visit/visit-dialog.component.tsx
Outdated
Show resolved
Hide resolved
brandones
reviewed
Mar 16, 2022
Comment on lines
27
to
29
| showToast: jest.fn(), | ||
| showNotification: jest.fn(), | ||
| updateVisit: jest.fn(), |
There was a problem hiding this comment.
Let's add mocks for these to core if they don't already exist
brandones
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
start-visit-formwhere if the time is 12 noon, it converts the time to the next day date. e.g15-march-2022 12:03 PMconverted to `16-march-2022 00:03 AM'Screenshots
Related Issue
https://issues.openmrs.org/projects/O3/issues/O3-1168?filter=myopenissues
Other