Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add basic support for a multi-column layout for custom dashboards #729

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

brandones
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

This adds basic support for multi-column layouts in custom dashboards. Things this does not do:

  • make it possible to configure widgets to take up different amounts of horizontal space
  • allow changing dashboard layout depending on whether or not the workspace is open

Screenshots

2022-06-25_11-54

@brandones
Copy link
Contributor Author

@ibacher
Copy link
Member

ibacher commented Jul 7, 2022

@brandones Nice! One small thing: how does this look with the workspace open?

@brandones
Copy link
Contributor Author

@ibacher Bad, it looks bad. This feature is definitely "use at implementer's own risk." The site that is requesting it is not using workspaces yet.

@brandones brandones merged commit f39567f into master Jul 11, 2022
@brandones brandones deleted the multi-column branch July 11, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants