O3-578: Restore Generic Dashboard Links #733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This is a very simple follow-up commit to O3-578 to fix a kind of obscure feature: the Generic Dashboards that are creatable via configuration rather than code. When calling
createDashboardLink()
, we're able to get thecurrentPath
passed down to theDashboardExtension
component. However, the Generic Dashboards widget directly creates aDashboardExtension
component in a context where we don't have thecurrentPath
design. This switches things so we rely on thelocation
supplied by the react-routeruseLocation()
hook which should work in both contexts and not add any noticeable overhead.Screenshots
Related Issue
Other