(fix) Migrate offline form concept label loading to new bulk endpoint #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roemer/openmrs-esm-patient-chart; branch 'master' of github.com:openmrs/openmrs-esm-patient-chart
ibacher
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Follow-up work for the bulk loading of form concept labels. This ensures that the new bulk fetching endpoint is also precached so that labels show up while offline.
Other
I unfortunately am unable to properly test this. In Dev3, there is currently no form for me. On the ICRC's server, the requests to the concept endpoint are intercepted by the firewall. 😞