Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) add __VERSION__ constant for form-entry-app #786

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Aug 25, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

I forgot that form-entry-app uses it's own custom webpack configuration... This adds the __VERSION__ constant to that app.

Screenshots

Related Issue

Other

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibacher ibacher merged commit 30fd2fb into main Aug 25, 2022
@ibacher ibacher deleted the fix-version-form-entry-app branch August 25, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants