Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

03-1429: Appointment Save and Close button. #790

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Conversation

hadijahkyampeire
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire commented Aug 29, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

Remove the condition for a selected service type as it was the one returning and stopping the submitting

Screenshots

This is to confirm that the submitting is now making an API call as expected.
Screenshot 2022-08-30 at 16 19 38

Related Issue

Appointment Save and Close button

@donaldkibet
Copy link
Member

@hadijahkyampeire please upload a screenshoot gif of the changes made

@@ -52,8 +52,6 @@ const AppointmentsForm: React.FC<DefaultWorkspaceProps> = ({ patientUuid, closeW
}

const handleSubmit = () => {
if (!selectedServiceType) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't selectedServiceType necessary for submitting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a required field by the backend but we were requiring it since we were getting the duration to make the endTime from the serviceType, but now that we mostly have no service types and we can access the durations on the service top level, it's better we don't make it a condition for submitting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadijahkyampeire ok, makes sense. What do you think @CynthiaKamau ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZacButko do you know if it is possible to make appointment endpoints point to this backend because it is the one that works? backend=[https://](http://loc/)data.kenyahmis.org:8500 --api-url=/openmrs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadijahkyampeire I'm not sure what you're asking.. for dev3 It would be preferable to get appointments working on that setup. If it's not pointing to a working instance right now we should make a talk post to get backend team to look at it.

if the question is just about syntax the better syntax would be --backend "https://data.kenyahmis.org --port 8500 ...

@hadijahkyampeire
Copy link
Contributor Author

@donaldkibet I have added a screenshot.

@ZacButko ZacButko merged commit d759ccf into main Sep 8, 2022
@ZacButko ZacButko deleted the hadijah/03-1429 branch September 8, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants