feat: Add current date appointments and fix issue with displaying past and upcoming appointments #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
force-pushed
the
bug/appointment-dates
branch
from
a933f22 to
245c330
Compare
|
Size Change: +346 B (0%) Total Size: 5.66 MB ℹ️ View Unchanged
|
makombe
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
LGTM @donaldkibet thanks. Just a small change there to effect
| <Tile className={styles.tile}> | ||
| <EmptyDataIllustration /> | ||
| <p className={styles.content}> | ||
| {t('noCurrentAppointments', 'There are current appointments to display for this patient')} |
There was a problem hiding this comment.
Suggested change
| {t('noCurrentAppointments', 'There are current appointments to display for this patient')} | |
| {t('noCurrentAppointments', 'There are no current appointments to display for this patient')} |
There was a problem hiding this comment.
I'd suggest:
"noCurrentAppointments": "There are no appointments scheduled for today to display for this patient",
denniskigen
reviewed
Nov 17, 2022
| <Tile className={styles.tile}> | ||
| <EmptyDataIllustration /> | ||
| <p className={styles.content}> | ||
| {t('noCurrentAppointments', 'There are current appointments to display for this patient')} |
There was a problem hiding this comment.
I'd suggest:
"noCurrentAppointments": "There are no appointments scheduled for today to display for this patient",
7059ddd to
baa25d4
Compare
donaldkibet
force-pushed
the
bug/appointment-dates
branch
from
9977cf2 to
5c5301c
Compare
donaldkibet
force-pushed
the
bug/appointment-dates
branch
from
5c5301c to
49e64a5
Compare
denniskigen
reviewed
Nov 21, 2022
denniskigen
approved these changes
Nov 21, 2022
icrc-agomes
pushed a commit
to icrc-agomes/openmrs-esm-patient-chart
that referenced
this pull request
Dec 19, 2022
…t and upcoming appointments (openmrs#867) * feat: Add current date `today` appointments tab * Add translation * Fix failing test * fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR addresses two issues:
PastandUpcomingappointments in the UI. Presently, appointments with UTC dates are displayed incorrectly.Todaytab to the content switcher that displays appointments for the present day. This information is useful in a clinical setup.Screenshots