Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O3-1626: Cleanup the patient chart appointments form #883

Merged
merged 3 commits into from
Nov 18, 2022
Merged

O3-1626: Cleanup the patient chart appointments form #883

merged 3 commits into from
Nov 18, 2022

Conversation

Rhotimee
Copy link
Contributor

@Rhotimee Rhotimee commented Nov 18, 2022 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

Remove the service type field in the appointments form

Screenshots

Before
image

After
image

Related Issue

JIRA Link

hadijahkyampeire
hadijahkyampeire approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rhotimee for this cleanup

@hadijahkyampeire hadijahkyampeire merged commit 8b4c1b8 into openmrs:main Nov 18, 2022
icrc-agomes pushed a commit to icrc-agomes/openmrs-esm-patient-chart that referenced this pull request Dec 19, 2022
@Rhotimee
O3-1626: Cleanup the patient chart appointments form (openmrs#883)
52011be 
* refactor: remove service type input and state from appointments form

* refactor: remove service type related tests

* refactor: remove service type from translation file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadijahkyampeire hadijahkyampeire hadijahkyampeire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rhotimee @hadijahkyampeire