Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O3-1634: UI Fixes for Test results viewer in Tablet and Small Desktop #893

Merged
merged 7 commits into from
Dec 12, 2022
Merged

O3-1634: UI Fixes for Test results viewer in Tablet and Small Desktop #893

merged 7 commits into from
Dec 12, 2022

Conversation

vasharma05
Copy link
Member

@vasharma05 vasharma05 commented Dec 5, 2022 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

This PR introduces the following UI fixes for the test results viewer in small desktop and tablet views.

  1. Fixing the UI for tablet view
  2. Fixing the UI when screen size transitions from small desktop to tablet view
  3. Hiding Trendline view for data which is not numeric
  4. Sticking the panel's timeline at top on scrolling

Screenshots

Screen.Recording.2022-12-05.at.4.20.06.PM.mov

Related Issue

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022 •
edited
Loading

Size Change: +3.69 kB (0%)

Total Size: 5.68 MB

Filename Size Change
packages/esm-form-entry-app/dist/744.37a392d90b51496e0291.js 0 B -10.6 kB (removed) 🏆
packages/esm-patient-test-results-app/dist/570.js 0 B -94.2 kB (removed) 🏆
packages/esm-form-entry-app/dist/744.a42ae575cb66685aa1f8.js 10.6 kB +10.6 kB (new file) 🆕
packages/esm-patient-test-results-app/dist/356.js 93 kB +93 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
packages/esm-form-entry-app/dist/231.f31b8b10cfb14d19c348.js 30.4 kB 0 B
packages/esm-form-entry-app/dist/574.a78c7d55ae3ded7efd21.js 123 B 0 B
packages/esm-form-entry-app/dist/807.ad2681da0d002e075ec7.js 123 B 0 B
packages/esm-form-entry-app/dist/openmrs-esm-form-entry-app.js 404 kB -1 B (0%)
packages/esm-generic-patient-widgets-app/dist/15.js 142 kB 0 B
packages/esm-generic-patient-widgets-app/dist/150.js 1.06 kB 0 B
packages/esm-generic-patient-widgets-app/dist/206.js 11.2 kB 0 B
packages/esm-generic-patient-widgets-app/dist/34.js 16.9 kB 0 B
packages/esm-generic-patient-widgets-app/dist/377.js 3.35 kB 0 B
packages/esm-generic-patient-widgets-app/dist/402.js 8.83 kB 0 B
packages/esm-generic-patient-widgets-app/dist/574.js 188 B 0 B
packages/esm-generic-patient-widgets-app/dist/652.js 96 kB 0 B
packages/esm-generic-patient-widgets-app/dist/709.js 6.67 kB 0 B
packages/esm-generic-patient-widgets-app/dist/782.js 5.27 kB 0 B
packages/esm-generic-patient-widgets-app/dist/784.js 2.64 kB 0 B
packages/esm-generic-patient-widgets-app/dist/807.js 243 B 0 B
packages/esm-generic-patient-widgets-app/dist/858.js 111 kB 0 B
packages/esm-generic-patient-widgets-app/dist/main.js 3.43 kB 0 B
packages/esm-generic-patient-widgets-app/dist/openmrs-esm-generic-patient-widgets-app.js 3.38 kB 0 B
packages/esm-patient-allergies-app/dist/134.js 8.38 kB 0 B
packages/esm-patient-allergies-app/dist/206.js 11.2 kB 0 B
packages/esm-patient-allergies-app/dist/265.js 2.48 kB 0 B
packages/esm-patient-allergies-app/dist/34.js 16.9 kB 0 B
packages/esm-patient-allergies-app/dist/402.js 8.81 kB 0 B
packages/esm-patient-allergies-app/dist/435.js 1.23 kB 0 B
packages/esm-patient-allergies-app/dist/574.js 674 B 0 B
packages/esm-patient-allergies-app/dist/708.js 5.46 kB 0 B
packages/esm-patient-allergies-app/dist/709.js 6.66 kB 0 B
packages/esm-patient-allergies-app/dist/755.js 3.82 kB 0 B
packages/esm-patient-allergies-app/dist/757.js 130 B 0 B
packages/esm-patient-allergies-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-allergies-app/dist/802.js 3.27 kB 0 B
packages/esm-patient-allergies-app/dist/807.js 1.06 kB 0 B
packages/esm-patient-allergies-app/dist/838.js 2.31 kB 0 B
packages/esm-patient-allergies-app/dist/858.js 111 kB 0 B
packages/esm-patient-allergies-app/dist/879.js 2.88 kB 0 B
packages/esm-patient-allergies-app/dist/911.js 129 kB 0 B
packages/esm-patient-allergies-app/dist/934.js 3.43 kB 0 B
packages/esm-patient-allergies-app/dist/main.js 3.43 kB 0 B
packages/esm-patient-allergies-app/dist/openmrs-esm-patient-allergies-app.js 3.41 kB 0 B
packages/esm-patient-appointments-app/dist/206.js 11.2 kB 0 B
packages/esm-patient-appointments-app/dist/327.js 8.23 kB 0 B
packages/esm-patient-appointments-app/dist/34.js 16.9 kB 0 B
packages/esm-patient-appointments-app/dist/358.js 222 B 0 B
packages/esm-patient-appointments-app/dist/361.js 121 kB 0 B
packages/esm-patient-appointments-app/dist/402.js 8.81 kB 0 B
packages/esm-patient-appointments-app/dist/574.js 535 B 0 B
packages/esm-patient-appointments-app/dist/709.js 6.66 kB 0 B
packages/esm-patient-appointments-app/dist/749.js 3.81 kB 0 B
packages/esm-patient-appointments-app/dist/757.js 131 B 0 B
packages/esm-patient-appointments-app/dist/76.js 806 B 0 B
packages/esm-patient-appointments-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-appointments-app/dist/807.js 734 B 0 B
packages/esm-patient-appointments-app/dist/840.js 4.35 kB 0 B
packages/esm-patient-appointments-app/dist/858.js 111 kB 0 B
packages/esm-patient-appointments-app/dist/879.js 2.88 kB 0 B
packages/esm-patient-appointments-app/dist/916.js 221 B 0 B
packages/esm-patient-appointments-app/dist/main.js 3.41 kB 0 B
packages/esm-patient-appointments-app/dist/openmrs-esm-patient-appointments-app.js 3.41 kB 0 B
packages/esm-patient-attachments-app/dist/168.js 6.5 kB 0 B
packages/esm-patient-attachments-app/dist/206.js 11.2 kB 0 B
packages/esm-patient-attachments-app/dist/34.js 16.9 kB 0 B
packages/esm-patient-attachments-app/dist/402.js 8.81 kB 0 B
packages/esm-patient-attachments-app/dist/433.js 93.3 kB 0 B
packages/esm-patient-attachments-app/dist/440.js 2.53 kB 0 B
packages/esm-patient-attachments-app/dist/473.js 6.45 kB +13 B (0%)
packages/esm-patient-attachments-app/dist/488.js 1.1 kB 0 B
packages/esm-patient-attachments-app/dist/492.js 6.07 kB 0 B
packages/esm-patient-attachments-app/dist/50.js 588 B 0 B
packages/esm-patient-attachments-app/dist/525.js 796 B 0 B
packages/esm-patient-attachments-app/dist/552.js 927 B 0 B
packages/esm-patient-attachments-app/dist/574.js 679 B 0 B
packages/esm-patient-attachments-app/dist/709.js 6.66 kB 0 B
packages/esm-patient-attachments-app/dist/757.js 131 B 0 B
packages/esm-patient-attachments-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-attachments-app/dist/807.js 1.02 kB 0 B
packages/esm-patient-attachments-app/dist/831.js 14.9 kB 0 B
packages/esm-patient-attachments-app/dist/832.js 7.71 kB 0 B
packages/esm-patient-attachments-app/dist/858.js 111 kB 0 B
packages/esm-patient-attachments-app/dist/main.js 3.38 kB 0 B
packages/esm-patient-attachments-app/dist/openmrs-esm-patient-attachments-app.js 3.38 kB 0 B
packages/esm-patient-banner-app/dist/150.js 874 B 0 B
packages/esm-patient-banner-app/dist/206.js 11.2 kB 0 B
packages/esm-patient-banner-app/dist/303.js 4.45 kB 0 B
packages/esm-patient-banner-app/dist/34.js 16.8 kB 0 B
packages/esm-patient-banner-app/dist/402.js 8.8 kB 0 B
packages/esm-patient-banner-app/dist/406.js 5.14 kB 0 B
packages/esm-patient-banner-app/dist/477.js 17.7 kB 0 B
packages/esm-patient-banner-app/dist/574.js 267 B 0 B
packages/esm-patient-banner-app/dist/645.js 1.42 kB 0 B
packages/esm-patient-banner-app/dist/693.js 933 B 0 B
packages/esm-patient-banner-app/dist/709.js 6.66 kB 0 B
packages/esm-patient-banner-app/dist/757.js 128 B 0 B
packages/esm-patient-banner-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-banner-app/dist/807.js 407 B 0 B
packages/esm-patient-banner-app/dist/82.js 1.4 kB 0 B
packages/esm-patient-banner-app/dist/858.js 111 kB 0 B
packages/esm-patient-banner-app/dist/998.js 8.07 kB 0 B
packages/esm-patient-banner-app/dist/main.js 3.38 kB 0 B
packages/esm-patient-banner-app/dist/openmrs-esm-patient-banner-app.js 3.37 kB 0 B
packages/esm-patient-biometrics-app/dist/107.js 353 B 0 B
packages/esm-patient-biometrics-app/dist/15.js 142 kB 0 B
packages/esm-patient-biometrics-app/dist/197.js 1.1 kB 0 B
packages/esm-patient-biometrics-app/dist/206.js 11.2 kB 0 B
packages/esm-patient-biometrics-app/dist/34.js 16.9 kB 0 B
packages/esm-patient-biometrics-app/dist/377.js 3.34 kB 0 B
packages/esm-patient-biometrics-app/dist/402.js 8.81 kB 0 B
packages/esm-patient-biometrics-app/dist/566.js 90.4 kB 0 B
packages/esm-patient-biometrics-app/dist/574.js 130 B 0 B
packages/esm-patient-biometrics-app/dist/709.js 6.66 kB 0 B
packages/esm-patient-biometrics-app/dist/757.js 130 B 0 B
packages/esm-patient-biometrics-app/dist/758.js 354 B 0 B
packages/esm-patient-biometrics-app/dist/762.js 2.35 kB 0 B
packages/esm-patient-biometrics-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-biometrics-app/dist/807.js 129 B 0 B
packages/esm-patient-biometrics-app/dist/858.js 111 kB 0 B
packages/esm-patient-biometrics-app/dist/879.js 2.88 kB 0 B
packages/esm-patient-biometrics-app/dist/892.js 5.98 kB 0 B
packages/esm-patient-biometrics-app/dist/986.js 5.45 kB 0 B
packages/esm-patient-biometrics-app/dist/main.js 3.43 kB 0 B
packages/esm-patient-biometrics-app/dist/openmrs-esm-patient-biometrics-app.js 3.42 kB 0 B
packages/esm-patient-chart-app/dist/1203.js 1.13 kB 0 B
packages/esm-patient-chart-app/dist/1522.js 494 B 0 B
packages/esm-patient-chart-app/dist/1630.js 949 B 0 B
packages/esm-patient-chart-app/dist/1806.js 9.21 kB 0 B
packages/esm-patient-chart-app/dist/274.js 2.38 kB 0 B
packages/esm-patient-chart-app/dist/2757.js 127 B 0 B
packages/esm-patient-chart-app/dist/2784.js 2.63 kB 0 B
packages/esm-patient-chart-app/dist/2903.js 9.3 kB 0 B
packages/esm-patient-chart-app/dist/2963.js 2.5 kB 0 B
packages/esm-patient-chart-app/dist/3574.js 1.79 kB 0 B
packages/esm-patient-chart-app/dist/383.js 10.7 kB 0 B
packages/esm-patient-chart-app/dist/4049.js 12.9 kB 0 B
packages/esm-patient-chart-app/dist/4202.js 1.37 kB 0 B
packages/esm-patient-chart-app/dist/4258.js 183 kB 0 B
packages/esm-patient-chart-app/dist/443.js 1.15 kB 0 B
packages/esm-patient-chart-app/dist/5047.js 2.47 kB 0 B
packages/esm-patient-chart-app/dist/5170.js 4.33 kB 0 B
packages/esm-patient-chart-app/dist/5485.js 478 B 0 B
packages/esm-patient-chart-app/dist/6002.js 447 B 0 B
packages/esm-patient-chart-app/dist/6034.js 16.8 kB 0 B
packages/esm-patient-chart-app/dist/6220.js 4.9 kB 0 B
packages/esm-patient-chart-app/dist/6422.js 2.5 kB 0 B
packages/esm-patient-chart-app/dist/6579.js 425 B 0 B
packages/esm-patient-chart-app/dist/6858.js 111 kB 0 B
packages/esm-patient-chart-app/dist/686.js 586 B 0 B
packages/esm-patient-chart-app/dist/6913.js 3.15 kB 0 B
packages/esm-patient-chart-app/dist/7244.js 469 B 0 B
packages/esm-patient-chart-app/dist/7371.js 3.57 kB 0 B
packages/esm-patient-chart-app/dist/7631.js 2.26 kB 0 B
packages/esm-patient-chart-app/dist/78.js 4.05 kB 0 B
packages/esm-patient-chart-app/dist/7807.js 1.99 kB 0 B
packages/esm-patient-chart-app/dist/781.js 2.32 kB 0 B
packages/esm-patient-chart-app/dist/8046.js 3 kB 0 B
packages/esm-patient-chart-app/dist/8708.js 4.26 kB 0 B
packages/esm-patient-chart-app/dist/8843.js 6.71 kB 0 B
packages/esm-patient-chart-app/dist/8879.js 2.88 kB 0 B
packages/esm-patient-chart-app/dist/8911.js 8.43 kB 0 B
packages/esm-patient-chart-app/dist/9331.js 2.47 kB 0 B
packages/esm-patient-chart-app/dist/9402.js 8.81 kB 0 B
packages/esm-patient-chart-app/dist/9469.js 468 B 0 B
packages/esm-patient-chart-app/dist/9663.js 3.09 kB 0 B
packages/esm-patient-chart-app/dist/9857.js 4.25 kB 0 B
packages/esm-patient-chart-app/dist/9908.js 3.27 kB 0 B
packages/esm-patient-chart-app/dist/main.js 6.34 kB 0 B
packages/esm-patient-chart-app/dist/openmrs-esm-patient-chart-app.js 3.52 kB 0 B
packages/esm-patient-conditions-app/dist/103.js 2.38 kB 0 B
packages/esm-patient-conditions-app/dist/188.js 2.42 kB 0 B
packages/esm-patient-conditions-app/dist/284.js 5.31 kB 0 B
packages/esm-patient-conditions-app/dist/34.js 16.9 kB 0 B
packages/esm-patient-conditions-app/dist/366.js 8.4 kB 0 B
packages/esm-patient-conditions-app/dist/402.js 8.81 kB 0 B
packages/esm-patient-conditions-app/dist/552.js 9.83 kB 0 B
packages/esm-patient-conditions-app/dist/574.js 375 B 0 B
packages/esm-patient-conditions-app/dist/674.js 3.19 kB 0 B
packages/esm-patient-conditions-app/dist/709.js 6.66 kB 0 B
packages/esm-patient-conditions-app/dist/757.js 131 B 0 B
packages/esm-patient-conditions-app/dist/76.js 833 B 0 B
packages/esm-patient-conditions-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-conditions-app/dist/807.js 600 B 0 B
packages/esm-patient-conditions-app/dist/858.js 111 kB 0 B
packages/esm-patient-conditions-app/dist/879.js 2.88 kB 0 B
packages/esm-patient-conditions-app/dist/941.js 5.64 kB 0 B
packages/esm-patient-conditions-app/dist/958.js 118 kB 0 B
packages/esm-patient-conditions-app/dist/main.js 3.43 kB 0 B
packages/esm-patient-conditions-app/dist/openmrs-esm-patient-conditions-app.js 3.42 kB 0 B
packages/esm-patient-forms-app/dist/206.js 11.2 kB 0 B
packages/esm-patient-forms-app/dist/216.js 410 B 0 B
packages/esm-patient-forms-app/dist/220.js 4.93 kB 0 B
packages/esm-patient-forms-app/dist/222.js 7.97 kB 0 B
packages/esm-patient-forms-app/dist/318.js 1.7 kB 0 B
packages/esm-patient-forms-app/dist/34.js 16.8 kB 0 B
packages/esm-patient-forms-app/dist/402.js 8.8 kB 0 B
packages/esm-patient-forms-app/dist/47.js 2.46 kB 0 B
packages/esm-patient-forms-app/dist/474.js 4.28 kB 0 B
packages/esm-patient-forms-app/dist/513.js 1.07 kB 0 B
packages/esm-patient-forms-app/dist/525.js 494 B 0 B
packages/esm-patient-forms-app/dist/574.js 470 B 0 B
packages/esm-patient-forms-app/dist/576.js 84.9 kB 0 B
packages/esm-patient-forms-app/dist/609.js 1.25 kB 0 B
packages/esm-patient-forms-app/dist/642.js 1.89 kB 0 B
packages/esm-patient-forms-app/dist/709.js 6.66 kB 0 B
packages/esm-patient-forms-app/dist/725.js 2.98 kB 0 B
packages/esm-patient-forms-app/dist/757.js 127 B 0 B
packages/esm-patient-forms-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-forms-app/dist/803.js 408 B 0 B
packages/esm-patient-forms-app/dist/807.js 722 B 0 B
packages/esm-patient-forms-app/dist/857.js 4.25 kB 0 B
packages/esm-patient-forms-app/dist/858.js 111 kB 0 B
packages/esm-patient-forms-app/dist/879.js 2.88 kB 0 B
packages/esm-patient-forms-app/dist/944.js 3.77 kB 0 B
packages/esm-patient-forms-app/dist/main.js 7.94 kB 0 B
packages/esm-patient-forms-app/dist/openmrs-esm-patient-forms-app.js 3.44 kB 0 B
packages/esm-patient-immunizations-app/dist/206.js 11.2 kB 0 B
packages/esm-patient-immunizations-app/dist/245.js 1.76 kB 0 B
packages/esm-patient-immunizations-app/dist/34.js 16.9 kB 0 B
packages/esm-patient-immunizations-app/dist/355.js 3.9 kB 0 B
packages/esm-patient-immunizations-app/dist/492.js 129 kB 0 B
packages/esm-patient-immunizations-app/dist/555.js 3.48 kB 0 B
packages/esm-patient-immunizations-app/dist/574.js 133 B 0 B
packages/esm-patient-immunizations-app/dist/684.js 1.25 kB 0 B
packages/esm-patient-immunizations-app/dist/709.js 6.67 kB 0 B
packages/esm-patient-immunizations-app/dist/757.js 133 B 0 B
packages/esm-patient-immunizations-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-immunizations-app/dist/807.js 133 B 0 B
packages/esm-patient-immunizations-app/dist/858.js 111 kB 0 B
packages/esm-patient-immunizations-app/dist/885.js 3.55 kB 0 B
packages/esm-patient-immunizations-app/dist/927.js 9.79 kB 0 B
packages/esm-patient-immunizations-app/dist/main.js 3.4 kB 0 B
packages/esm-patient-immunizations-app/dist/openmrs-esm-patient-immunizations-app.js 3.37 kB 0 B
packages/esm-patient-medications-app/dist/144.js 1.65 kB 0 B
packages/esm-patient-medications-app/dist/206.js 11.2 kB 0 B
packages/esm-patient-medications-app/dist/238.js 1.76 kB 0 B
packages/esm-patient-medications-app/dist/300.js 14.4 kB 0 B
packages/esm-patient-medications-app/dist/34.js 16.9 kB 0 B
packages/esm-patient-medications-app/dist/352.js 6.66 kB 0 B
packages/esm-patient-medications-app/dist/435.js 1.47 kB 0 B
packages/esm-patient-medications-app/dist/489.js 810 B 0 B
packages/esm-patient-medications-app/dist/544.js 9.46 kB 0 B
packages/esm-patient-medications-app/dist/574.js 1.11 kB 0 B
packages/esm-patient-medications-app/dist/671.js 4.74 kB 0 B
packages/esm-patient-medications-app/dist/695.js 634 B 0 B
packages/esm-patient-medications-app/dist/700.js 5.14 kB 0 B
packages/esm-patient-medications-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-medications-app/dist/807.js 1.71 kB 0 B
packages/esm-patient-medications-app/dist/843.js 6.72 kB 0 B
packages/esm-patient-medications-app/dist/858.js 111 kB 0 B
packages/esm-patient-medications-app/dist/87.js 7.34 kB 0 B
packages/esm-patient-medications-app/dist/879.js 2.88 kB 0 B
packages/esm-patient-medications-app/dist/985.js 101 kB 0 B
packages/esm-patient-medications-app/dist/main.js 3.44 kB 0 B
packages/esm-patient-medications-app/dist/openmrs-esm-patient-medications-app.js 3.41 kB 0 B
packages/esm-patient-notes-app/dist/104.js 5.95 kB 0 B
packages/esm-patient-notes-app/dist/114.js 1.39 kB 0 B
packages/esm-patient-notes-app/dist/161.js 117 kB 0 B
packages/esm-patient-notes-app/dist/188.js 2.42 kB 0 B
packages/esm-patient-notes-app/dist/34.js 16.8 kB 0 B
packages/esm-patient-notes-app/dist/402.js 8.8 kB 0 B
packages/esm-patient-notes-app/dist/552.js 9.82 kB 0 B
packages/esm-patient-notes-app/dist/556.js 5.21 kB 0 B
packages/esm-patient-notes-app/dist/574.js 642 B 0 B
packages/esm-patient-notes-app/dist/6.js 1.15 kB 0 B
packages/esm-patient-notes-app/dist/667.js 354 B 0 B
packages/esm-patient-notes-app/dist/709.js 6.66 kB 0 B
packages/esm-patient-notes-app/dist/757.js 127 B 0 B
packages/esm-patient-notes-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-notes-app/dist/807.js 903 B 0 B
packages/esm-patient-notes-app/dist/838.js 347 B 0 B
packages/esm-patient-notes-app/dist/858.js 111 kB 0 B
packages/esm-patient-notes-app/dist/879.js 2.88 kB 0 B
packages/esm-patient-notes-app/dist/892.js 4.59 kB 0 B
packages/esm-patient-notes-app/dist/893.js 3.74 kB 0 B
packages/esm-patient-notes-app/dist/940.js 4.51 kB 0 B
packages/esm-patient-notes-app/dist/main.js 3.46 kB 0 B
packages/esm-patient-notes-app/dist/openmrs-esm-patient-notes-app.js 3.43 kB 0 B
packages/esm-patient-programs-app/dist/206.js 11.2 kB 0 B
packages/esm-patient-programs-app/dist/238.js 3.32 kB 0 B
packages/esm-patient-programs-app/dist/250.js 126 kB 0 B
packages/esm-patient-programs-app/dist/34.js 16.9 kB 0 B
packages/esm-patient-programs-app/dist/402.js 8.81 kB 0 B
packages/esm-patient-programs-app/dist/435.js 874 B 0 B
packages/esm-patient-programs-app/dist/461.js 1.79 kB 0 B
packages/esm-patient-programs-app/dist/574.js 550 B 0 B
packages/esm-patient-programs-app/dist/641.js 3.28 kB 0 B
packages/esm-patient-programs-app/dist/709.js 6.66 kB 0 B
packages/esm-patient-programs-app/dist/733.js 4.74 kB 0 B
packages/esm-patient-programs-app/dist/757.js 129 B 0 B
packages/esm-patient-programs-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-programs-app/dist/807.js 829 B 0 B
packages/esm-patient-programs-app/dist/821.js 3.74 kB 0 B
packages/esm-patient-programs-app/dist/858.js 111 kB 0 B
packages/esm-patient-programs-app/dist/879.js 2.88 kB 0 B
packages/esm-patient-programs-app/dist/main.js 3.42 kB 0 B
packages/esm-patient-programs-app/dist/openmrs-esm-patient-programs-app.js 3.4 kB 0 B
packages/esm-patient-test-results-app/dist/0.js 8.33 kB 0 B
packages/esm-patient-test-results-app/dist/150.js 1.15 kB 0 B
packages/esm-patient-test-results-app/dist/206.js 11.2 kB 0 B
packages/esm-patient-test-results-app/dist/34.js 16.9 kB 0 B
packages/esm-patient-test-results-app/dist/411.js 2.17 kB 0 B
packages/esm-patient-test-results-app/dist/426.js 1.93 kB 0 B
packages/esm-patient-test-results-app/dist/446.js 4.29 kB +2 B (0%)
packages/esm-patient-test-results-app/dist/574.js 487 B +41 B (+9%) 🔍
packages/esm-patient-test-results-app/dist/709.js 6.67 kB 0 B
packages/esm-patient-test-results-app/dist/719.js 3.97 kB +26 B (+1%)
packages/esm-patient-test-results-app/dist/757.js 131 B 0 B
packages/esm-patient-test-results-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-test-results-app/dist/807.js 627 B 0 B
packages/esm-patient-test-results-app/dist/851.js 181 kB 0 B
packages/esm-patient-test-results-app/dist/858.js 111 kB 0 B
packages/esm-patient-test-results-app/dist/896.js 826 B 0 B
packages/esm-patient-test-results-app/dist/90.js 41.1 kB +4.66 kB (+13%) ⚠️
packages/esm-patient-test-results-app/dist/959.js 9.5 kB 0 B
packages/esm-patient-test-results-app/dist/main.js 3.46 kB -1 B (0%)
packages/esm-patient-test-results-app/dist/openmrs-esm-patient-test-results-app.js 3.38 kB -1 B (0%)
packages/esm-patient-vitals-app/dist/143.js 7.17 kB 0 B
packages/esm-patient-vitals-app/dist/206.js 11.2 kB 0 B
packages/esm-patient-vitals-app/dist/272.js 1.38 kB 0 B
packages/esm-patient-vitals-app/dist/34.js 16.8 kB 0 B
packages/esm-patient-vitals-app/dist/377.js 3.34 kB 0 B
packages/esm-patient-vitals-app/dist/402.js 8.8 kB 0 B
packages/esm-patient-vitals-app/dist/574.js 705 B 0 B
packages/esm-patient-vitals-app/dist/630.js 353 B 0 B
packages/esm-patient-vitals-app/dist/638.js 355 B 0 B
packages/esm-patient-vitals-app/dist/709.js 6.66 kB 0 B
packages/esm-patient-vitals-app/dist/74.js 96.3 kB 0 B
packages/esm-patient-vitals-app/dist/757.js 128 B 0 B
packages/esm-patient-vitals-app/dist/761.js 6.57 kB 0 B
packages/esm-patient-vitals-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-vitals-app/dist/807.js 993 B 0 B
packages/esm-patient-vitals-app/dist/855.js 143 kB 0 B
packages/esm-patient-vitals-app/dist/858.js 111 kB 0 B
packages/esm-patient-vitals-app/dist/863.js 6.11 kB +92 B (+2%)
packages/esm-patient-vitals-app/dist/879.js 2.88 kB 0 B
packages/esm-patient-vitals-app/dist/892.js 5.98 kB 0 B
packages/esm-patient-vitals-app/dist/main.js 3.44 kB 0 B
packages/esm-patient-vitals-app/dist/openmrs-esm-patient-vitals-app.js 3.41 kB 0 B

compressed-size-action

FlorianRappl
FlorianRappl reviewed Dec 5, 2022
View reviewed changes
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general - I'd just love to see a bit more flexibility / less code duplication. Otherwise, great change!

packages/esm-patient-test-results-app/src/grouped-timeline/grouped-timeline.tsx Outdated Show resolved Hide resolved
packages/esm-patient-test-results-app/src/panel-timeline/helpers.tsx Show resolved Hide resolved
FlorianRappl
FlorianRappl approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vasharma05
Copy link
Member Author

Thank you @FlorianRappl !

@vasharma05 vasharma05 merged commit 4500a61 into main Dec 12, 2022
@vasharma05 vasharma05 deleted the O3-1634 branch December 12, 2022 11:21
icrc-agomes pushed a commit to icrc-agomes/openmrs-esm-patient-chart that referenced this pull request Dec 19, 2022
@vasharma05
O3-1634: UI Fixes for Test results viewer in Tablet and Small Desktop (…
9f99c8d 
…openmrs#893)

* UI changes for tablet view

* UI refinements

* Upated translations

* Removed the Grid, Column due to the breaking UI for small desktop

* Removed the trendline link if the result value is a string value

* Review changes

* Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianRappl FlorianRappl FlorianRappl approved these changes

@denniskigen denniskigen Awaiting requested review from denniskigen

@hadijahkyampeire hadijahkyampeire Awaiting requested review from hadijahkyampeire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasharma05 @FlorianRappl