O3-1713: Order basket drug search implemented with SWR #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasharma05
requested review from
FlorianRappl,
denniskigen and
hadijahkyampeire
|
Size Change: -169 kB (-3%) Total Size: 5.72 MB
ℹ️ View Unchanged
|
...dications-app/src/order-basket/order-basket-search/order-basket-search-results.component.tsx
Outdated
Show resolved
Hide resolved
|
Hi @FlorianRappl, I've done the requested changes. Please re-review the changes. |
…ient-chart into O3-1713-drug-search-fix
...dications-app/src/order-basket/order-basket-search/order-basket-search-results.component.tsx
Outdated
Show resolved
Hide resolved
...es/esm-patient-medications-app/src/order-basket/order-basket-search/drug-search.resource.tsx
Show resolved
Hide resolved
...dications-app/src/order-basket/order-basket-search/order-basket-search-results.component.tsx
Outdated
Show resolved
Hide resolved
hadijahkyampeire
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Very nice work @vasharma05 this will really improve the experience with the drug ordering. Feel free to merge after everything is ready.
…ient-chart into O3-1713-drug-search-fix
|
Hey, @vasharma05, superb work! Could you get rid of this line. I suspect this is what's cancelling the encounter request when a user launches the order basket in the workspace for the first time.
|
denniskigen
reviewed
Dec 22, 2022
...dications-app/src/order-basket/order-basket-search/order-basket-search-results.component.tsx
Show resolved
Hide resolved
denniskigen
reviewed
Dec 22, 2022
| hasIconOnly={true} | ||
| renderIcon={(props) => <ShoppingCart size={16} {...props} />} | ||
| iconDescription={t('directlyAddToBasket', 'Immediately add to basket')} | ||
| onClick={() => handleSearchResultClicked(orderItem, true)} |
There was a problem hiding this comment.
Suggested change
| onClick={() => handleSearchResultClicked(orderItem, true)} | |
| onClick={() => handleSearchResultClicked(orderItem, true)} | |
| tooltipPosition="left" | |
| tooltipAlignment="end" |
To avoid the tooltip getting cut off:
There was a problem hiding this comment.
Thanks a lot!
Duly noted.
|
One more thing, I've noticed that the list isn't scrollable when you have many search results.
|
|
Thanks for the helpful observations and suggestions @denniskigen |
FlorianRappl
reviewed
Jan 3, 2023
...es/esm-patient-medications-app/src/order-basket/order-basket-search/drug-search.resource.tsx
Show resolved
Hide resolved
…ient-chart into O3-1713-drug-search-fix
|
Thanks a lot for pointing out the changes and useful reviews @FlorianRappl @denniskigen @hadijahkyampeire! |
…ient-chart into O3-1713-drug-search-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR introduces the following changes:
searchMedicationsfunction previously used to order medications withuseDrugSearchScreenshots
Improved skeletons
No results found view
The new and improved flow
Screen.Recording.2022-12-22.at.3.54.12.AM.mov
Tablet view improved
Related Issue
https://issues.openmrs.org/browse/O3-1713
Other