-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(bug fix): Free text dosage drug ordering not working as expected.[03-1744 and 03-1746] #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +227 B (0%) Total Size: 5.72 MB ℹ️ View Unchanged
|
hadijahkyampeire
changed the title
(bug fix): Free text dosage drug ordering not working as expected.[03-1744]
(bug fix): Free text dosage drug ordering not working as expected.[03-1744 and 03-1746]
Jan 12, 2023
vasharma05
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hadijahkyampeire! I haven't tested the code, but the changes looks promising.
Thanks for working on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
null dosage and unit
so to accessunit.value
would throw an error, so adding a ternary check fixes it.Screenshots
Missing margin
Fixed margin
Free text save and sign order fix
free-text-drug-order.mov
Related Issue
Other