(feat) O3-1738: Show more than just ten items in conditions widget #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadijahkyampeire
requested review from
denniskigen,
vasharma05,
gracepotma,
ibacher and
kdaud
|
Size Change: +1.09 kB (0%) Total Size: 5.72 MB
ℹ️ View Unchanged
|
|
Thanks @hadijahkyampeire I am going to test the changes to night and get the feedback asap. |
|
Thanks so much for your very quick work on this @hadijahkyampeire! This is indeed an improvement and I support merging it since it fixes the underlying issue. However many, many patients have >10 conditions, and we wouldn't want serious ones to be hidden behind pagination. Actually your screenshot in the ticket is a good example, where the very important Diagnoses of "Heart Failure" & Type 1 diabetes would be buried in Page #2. So there will need to be a second PR (or we should change this one I guess?). If it's easier than using the limit-less logic, could we just set the pagination length for this widget to default to 100 conditions? |
|
Thanks, @gracepotma I can remove the pagination and we just make the table scrollable if the conditions become very many. |
vasharma05
requested changes
Jan 17, 2023
packages/esm-patient-conditions-app/src/conditions/conditions.resource.tsx
Outdated
Show resolved
Hide resolved
|
Hello @dkayiwa, do you know if there is a place where I can find FHIR endpoints for conditions well documented with expected payload, queryParams, response etc. That would be helpful in identifying whether pagination can be done on the backend (if yes what params do I pass), Also I am adding |
|
Hey @gracepotma ! Instead of removing the pagination to pull out important conditions, shouldn't there be a priority among the conditions so that we can order the conditions, instead of filling the page with around 100 conditions? |
vasharma05
approved these changes
Jan 17, 2023
denniskigen
changed the title
|
@vasharma05 fair question re. the ordering by severity; however, I don't believe we should implement something like that for 2 reasons: (1) different types of clinicians can have very different opinions about what is higher priority (e.g. a cardiologist will have a different opinion than an oncologist, etc), and (2) it would become something of a metadata management nightmare. Mayyyybe in the future we could have something like a move up/move down UI that clinicians could use to reorder the list but again for reasons #1 and #2 I don't think it would work out long-term. I'm happy with how it looks for now with the long-page view :) Although of course if we find there are performance concerns due to this implementation, I'm happy to reevaluate. So given this information - @vasharma05 is there anything else you meant by "implementing this in a proper way in the future"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
500results from the Backend so as to increase the returned conditions.Screenshots
Video recording
paginated.conditions.mov
Related Issue
Other