(refactor) Refactor registration form cancel modal to match conventions #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the registration form's cancel modal to match new modal naming and registration conventions. Modals are now registered in the routes registry file under the `modals`. The naming convention has also changed - modals now use the `*.modal.tsx` suffix. I've also amended the modal to use Carbon's ModalBody, ModalHeader, and ModalFooter components instead of using divs with custom classes. Finally, I've amended the modal title and content to align with other confirmation modals in O3.
|
Size Change: -59.3 kB (-1%) Total Size: 5.86 MB
ℹ️ View Unchanged
|
vasharma05
approved these changes
Aug 28, 2024
|
Thanks! |
chibongho
pushed a commit
that referenced
this pull request
Aug 30, 2024
…ed occupancy (#1213) * feat-metrics * update metrics * correct test * refactor useAdmission * fix e2e tests * (refactor) Refactor registration form cancel modal to match conventions (#1294) This PR refactors the registration form's cancel modal to match new modal naming and registration conventions. Modals are now registered in the routes registry file under the `modals`. The naming convention has also changed - modals now use the `*.modal.tsx` suffix. I've also amended the modal to use Carbon's ModalBody, ModalHeader, and ModalFooter components instead of using divs with custom classes. Finally, I've amended the modal title and content to align with other confirmation modals in O3. * (feat) 03-3404: follow-up -ensure the dateAppointmentScheduled <= appointmentDate (#1295) * correct yarn.lock --------- Co-authored-by: Dennis Kigen <[email protected]> Co-authored-by: Lucy Jemutai <[email protected]>
chibongho
pushed a commit
that referenced
this pull request
Sep 23, 2024
…rics (#1307) * feat-metrics * update metrics * correct test * refactor useAdmission * fix e2e tests * (refactor) Refactor registration form cancel modal to match conventions (#1294) This PR refactors the registration form's cancel modal to match new modal naming and registration conventions. Modals are now registered in the routes registry file under the `modals`. The naming convention has also changed - modals now use the `*.modal.tsx` suffix. I've also amended the modal to use Carbon's ModalBody, ModalHeader, and ModalFooter components instead of using divs with custom classes. Finally, I've amended the modal title and content to align with other confirmation modals in O3. * (feat) 03-3404: follow-up -ensure the dateAppointmentScheduled <= appointmentDate (#1295) * correct yarn.lock * fix metrics calculations * add internationalization * correct mocks * add dir attribute * remove i18n code * clean code --------- Co-authored-by: Dennis Kigen <[email protected]> Co-authored-by: Lucy Jemutai <[email protected]>
chibongho
pushed a commit
that referenced
this pull request
Oct 7, 2024
…ng occupied beds (#1333) * feat-metrics * update metrics * correct test * refactor useAdmission * fix e2e tests * (refactor) Refactor registration form cancel modal to match conventions (#1294) This PR refactors the registration form's cancel modal to match new modal naming and registration conventions. Modals are now registered in the routes registry file under the `modals`. The naming convention has also changed - modals now use the `*.modal.tsx` suffix. I've also amended the modal to use Carbon's ModalBody, ModalHeader, and ModalFooter components instead of using divs with custom classes. Finally, I've amended the modal title and content to align with other confirmation modals in O3. * (feat) 03-3404: follow-up -ensure the dateAppointmentScheduled <= appointmentDate (#1295) * correct yarn.lock * fix metrics calculations * add internationalization * correct mocks * add dir attribute * remove i18n code * clean code * use admissionLocation as source of truth * Update ward-view.resource.ts --------- Co-authored-by: Dennis Kigen <[email protected]> Co-authored-by: Lucy Jemutai <[email protected]>
chibongho
pushed a commit
that referenced
this pull request
Oct 7, 2024
* feat-metrics * update metrics * correct test * refactor useAdmission * fix e2e tests * (refactor) Refactor registration form cancel modal to match conventions (#1294) This PR refactors the registration form's cancel modal to match new modal naming and registration conventions. Modals are now registered in the routes registry file under the `modals`. The naming convention has also changed - modals now use the `*.modal.tsx` suffix. I've also amended the modal to use Carbon's ModalBody, ModalHeader, and ModalFooter components instead of using divs with custom classes. Finally, I've amended the modal title and content to align with other confirmation modals in O3. * (feat) 03-3404: follow-up -ensure the dateAppointmentScheduled <= appointmentDate (#1295) * correct yarn.lock * fix metrics calculations * add internationalization * correct mocks * add dir attribute * remove i18n code * clean code * use admissionLocation as source of truth * fix patient error --------- Co-authored-by: Dennis Kigen <[email protected]> Co-authored-by: Lucy Jemutai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR refactors the registration form's cancel modal to match new modal naming and registration conventions. Modals are now registered in the
modalskey of the routes registry file (routes.json). The naming convention has also changed - modals now use the*.modal.tsxsuffix. I've also amended the modal to use Carbon'sModalBody,ModalHeader, andModalFootercomponents instead of divs with custom classes. Finally, I've amended the modal title and content to align with other confirmation modals in O3.Screenshots
Before
After
Related Issue
Other