(fix) O3-1491 Contact Details should be dynamically loaded for Patient Banner #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -45.1 kB (-2%) Total Size: 2.89 MB
ℹ️ View Unchanged
|
brandones
requested review from
mogoodrich
and removed request for
denniskigen
mogoodrich
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
@brandones I'm not fully up on all this code so didn't give a deep review, but generally LGTM, I added a couple small comments, thanks!
| } | ||
|
|
||
| const Address: React.FC<{ address: AddressType }> = ({ address }) => { | ||
| const PatientLists: React.FC<{ patientUuid: string }> = ({ patientUuid }) => { |
There was a problem hiding this comment.
When committing, would be worth noting that you added in the patient list functionality as part of this ticket as well.
There was a problem hiding this comment.
Oh yeah that's right! Thanks
| const { t } = useTranslation(); | ||
| const getAddressKey = (url) => url.split('#')[1]; | ||
| /* | ||
| DO NOT REMOVE THIS COMMENT UNLESS YOU UNDERSTAND WHY IT IS HERE |
There was a problem hiding this comment.
Might be helpful instead to just explain why it is there so newbies can learn this best practice for translation keys that are dynamically generated.
There was a problem hiding this comment.
Ha yeah it's not a great comment, it's copy-pasted from the other Patient Banner implementation. But I will be refactoring them soon anyway: openmrs/openmrs-esm-patient-chart#1645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This brings the patient-search contact section to parity with the patient chart patient banner, for better or worse. This is not exactly conformant with the designs, but I propose to bring both into conformance with the designs later.
It uses the address from the fhir Patient object, rather than a hard-coded set of address fields. It also adds patient lists support.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-1491