fix: make revalidateTags no-op when list of tags is empty
#2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
serhalp
previously approved these changes
Dec 19, 2024
tests/integration/simple-app.test.ts
Outdated
| @@ -22,6 +24,8 @@ import { | |||
| startMockBlobStore, | |||
| } from '../utils/helpers.js' | |||
| import { nextVersionSatisfies } from '../utils/next-version-helpers.mjs' | |||
| import { purgeCache } from '@netlify/functions' | |||
| import { afterEach } from 'node:test' | |||
There was a problem hiding this comment.
🤔 shouldn't this be from vitest like all the others?
There was a problem hiding this comment.
oooh, yes, this was result of import being automatically added and me not noticing it was wrong one
Comment on lines
+258
to
+259
| // allow for cache entry to get stale | ||
| await new Promise((res) => setTimeout(res, 2000)) |
There was a problem hiding this comment.
is mocking and advancing the clock here problematic?
There was a problem hiding this comment.
we use above in plenty of other places that check behaviors related to stale cache items so I just the same method here
I'm not sure if attempting to mock time would work - conceptually it should of course, but not sure it's worth doing that as most time is spent on setting up fixtures rather than running the test itself anyway (at least in this case)
There was a problem hiding this comment.
I'll go ahead and keep this as is in effort to get this fix out and would say moving to mocking time instead of using ~sleep is something to consider (across all unit and integration tests and not just this one) - just let's not use this PR for this
pieh
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the
revalidateTagscall a no-op when the array of tags is empty.Tests
Added integration test with scenario resulting in Next.js calling
CacheHandler.revalidateTagwith empty array of tags and ensuring purge API endpoint is not being usedRelevant links (GitHub issues, etc.) or a picture of cute animal
https://linear.app/netlify/issue/FRB-1536/dont-call-purgecache-when-tags-is-empty-array