additional-tests-for-adapter

[michmuel]

Closes #1880

[michmuel]

@svamaa, @voisardf, @vvmruder

The test test_get_session_that_does_not_exists fails due to

pyramid_oereb/tests/conftest.py

Line 137 in c8201ee

@pytest.fixture(scope='session')

.

Options:

• change the scope of the fixture, and explicitly include the function in 20-30 tests that require this patch
• move the adapter tests in a folder on a higher directory level. Structure of code and tests would differ in this case.

What shall we do?

[svamaa]

Options:

• change the scope of the fixture, and explicitly include the function in 20-30 tests that require this patch
• move the adapter tests in a folder on a higher directory level. Structure of code and tests would differ in this case.

What shall we do?

How would you estimate the payload for the first option? It seems to me to be the cleaner option but I'm not sure if it exceeds the goal of this ticket?

[michmuel]

I guess the first option is doable. Seems to be almost only copy and paste.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c139975) 80.59% compared to head (e050c84) 80.59%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1904   +/-   ##
=======================================
  Coverage   80.59%   80.59%           
=======================================
  Files         125      125           
  Lines        5266     5266           
=======================================
  Hits         4244     4244           
  Misses       1022     1022           

Flag	Coverage Δ
unittests	80.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michmuel]

I had again a look at

pyramid_oereb/tests/conftest.py

Line 228 in c8201ee

def dbsession(test_db_engine):

Balancing effort and yield I moved the adapter tests into a separate directory.

[voisardf]

Looks good to me and reorganised tests pass in my local instance

[svamaa]

Looks good to me!
Thanks for the work!

[voisardf]

sorry I didn't answer earlier. Still ok for me, thanks 👍