Added more tests of fit_beta_mixture and meta_analytic to reproduce known examples from R #16
Conversation
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Thanks @brockk - do you maybe want to first merge this into my branch with this PR? |
Yes of course, good idea. I have updated that. |
design/ReconcileWithR.jl
Outdated
| @@ -335,7 +335,7 @@ Turing = "~0.29.3" | |||
| PLUTO_MANIFEST_TOML_CONTENTS = """ | |||
| # This file is machine-generated - editing it directly is not advised | |||
|
|
|||
| julia_version = "1.9.3" | |||
| julia_version = "1.9.1" | |||
There was a problem hiding this comment.
are you sure you want to use a lower version? maybe even upgrade to 1.10 could be interesting?
There was a problem hiding this comment.
This was of course a change automatically generated by Pluto that reflects my Julia version is slightly older than the previous committer (I am guessing you, cos I have not changed my Julia install). I am just going to roll this change back. I like the idea of trying under 1.10 but not today!
test/test_fit_beta_mixture.jl
Outdated
| @test std(mix_small) ≈ std(pi_star) atol = 0.01 | ||
|
|
||
|
|
||
| # Large historical dataset |
There was a problem hiding this comment.
maybe split this in 2 tests, one for small, one for large dataset?
| check_numerical(map_small, [:a], [0.17], atol = 0.01) | ||
| check_numerical(map_small, [:b], [0.51], atol = 0.01) | ||
|
|
||
|
|
Note - this branch branches from 3_fit_beta_mixture because that branch contains pre-requisite code that is not yet in main.