Bugfix in JPEG2000 module #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JPEG2000 module did not parse a JPEG2000 codestream correctly when the length of a tile-part in a SOT marker segment was set to 0. This means that the tile-part contains all data in the remaining code stream. (See https://web.archive.org/web/20130810200214/http://www.jpeg.org/public/fcd15444-1.pdf section A.4.2) JHOVE however would interpret this incorrectly as meaning "literally 0", thus expecting the beginning of the next marker segment where in fact the tile-part bytestream starts.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## integration #997 +/- ##
==============================================
Coverage 47.15% 47.15%
Complexity 1102 1102
==============================================
Files 58 58
Lines 8993 8993
Branches 1618 1618
==============================================
Hits 4241 4241
Misses 4224 4224
Partials 528 528 ☔ View full report in Codecov by Sentry. |
|
Lots of example files that illustrate this bug here: https://www.opengeodata.nrw.de/produkte/geobasis/lusat/akt/dop/dop_jp2_f10/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JPEG2000 module did not parse a JPEG2000 codestream correctly when the length of a tile-part in a SOT marker segment was set to 0. This means that the tile-part contains all data in the remaining code stream. (See https://web.archive.org/web/20130810200214/http://www.jpeg.org/public/fcd15444-1.pdf section A.4.2) JHOVE however would interpret this incorrectly as meaning "literally 0", thus expecting the beginning of the next marker segment where in fact the tile-part bytestream starts.