Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen dependency version constraints wherever possible #19

Merged
merged 8 commits into from
Nov 7, 2022

Conversation

karalekas
Copy link
Collaborator

@karalekas karalekas commented Oct 30, 2022

  • Changes carets to >= wherever sensical.
  • typing-extensions: Lower bound changed from 4.3.0 to 3.10.0.2.
  • mypy-extensions: Lower bound changed from 0.4.3. to 0.2.
  • openpulse: Upgrades to 0.4.1 (this dependency is particularly critical for OQpy).
  • mypy: Upgrades to latest version (0.982).
  • numpy: Does a much better job of specifying constraints on a per-Python-version basis.
  • Adds support for Python 3.11 to CI/CD.
  • Adds a nightly CI job to test the poetry lock file.
  • Adds some color around why we've chosen the versions we've chosen.

With @PhilReinhold.

@PhilReinhold
Copy link
Collaborator

On the subject of loosening constraints, I think perhaps, since oqpy is a library not an application, we should remove all version upper bounds unless we know they are required. To that end I think (with the exception of openpulse whose implementation details we depend on heavily, and which should probably be specified using ==) all of the caret specifiers should be instead >= specifiers.

@karalekas karalekas changed the title Loosen version constraint for typing-extensions Loosen version constraints wherever possible Nov 6, 2022
@karalekas karalekas changed the title Loosen version constraints wherever possible Loosen dependency version constraints wherever possible Nov 6, 2022
@karalekas
Copy link
Collaborator Author

Made a couple more tweaks but I think this is ready to go now.

@PhilReinhold PhilReinhold merged commit 32cb438 into main Nov 7, 2022
@natestemen
Copy link

Is there an estimate for when these changes will be released? We're looking to support python 3.11 over on Mitiq.

@karalekas karalekas deleted the loosen-dependencies branch November 21, 2022 01:50
@karalekas
Copy link
Collaborator Author

@natestemen we're targeting this week for a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants