Add support for arguments & return types to defcals #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcjaskula-aws
force-pushed
the
jcjaskula-aws/add_defcal_args
branch
from
e21617e to
326c330
Compare
oqpy/quantum_types.py
Outdated
| program: Program, | ||
| qubits: Union[Qubit, list[Qubit]], | ||
| name: str, | ||
| arguments: Optional[list[Union[_ClassicalVar, str]]] = None, |
There was a problem hiding this comment.
The behavior for fixed parameters is not quite right here, in that if we reparse the generated openqasm it won't match the AST we store. The issue is assuming the string is an identifier. In fact the value you pass in your examples is not an identifier, but instead the binary expression pi/2.
I think the type here should be Optional[list[AstConvertible]] and shouldn't take arbitrary strings.
We may also want to define a module constant oqpy.pi = AngleType(name="pi", needs_declaration=False). so that the user need not define a pi constant for themselves
There was a problem hiding this comment.
It won't with the reference parser indeed. I'll see if I can be satisfied with OQPyExpression.
PhilReinhold
approved these changes
Nov 12, 2022
karalekas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for arguments and return type in defcal.
Arguments are provided via a list of ASTConvertible. Classical variables are passed to the defcal block through the context manager.
Return types are ast.ClassicalType or OQpy types.
The keys of the self.defcal dict have been modified to include a tuple of arguments.
Closes #7