Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nested subroutines and if statements in subroutines #53

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

PhilReinhold
Copy link
Collaborator

We encountered some errors using subroutines:

  • If statements without accompanying else statements were being dropped in the output
  • Using subroutines within a subroutine did not cause the inner subroutine definition to be added to the program
  • Variables used within a subroutine are not properly autodeclared within that subroutine.

Copy link
Collaborator

@jcjaskula-aws jcjaskula-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhilReinhold PhilReinhold merged commit 0af69d9 into main Jul 10, 2023
@jcjaskula-aws jcjaskula-aws deleted the pcrein/nested-subroutine-if branch June 17, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants