Consider cases when ExpressionConvertible returns float, int, duration #89
+35
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcjaskula-aws
force-pushed
the
jcjaskula-aws/ExpressionConvertible_returns_float
branch
from
09a5d05 to
8cb731a
Compare
|
Looks good to me, let's just update the |
PhilReinhold
approved these changes
Jun 17, 2024
jcjaskula-aws
deleted the
jcjaskula-aws/ExpressionConvertible_returns_float
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an
ExpressionConvertiblereturns a float, int or a duration, this can still be converted to a duration.