Add quir.declare_parameter, quir.load_parameter and generate quir.circuits #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
mbhealy
approved these changes
May 1, 2023
taalexander
requested changes
May 1, 2023
| @@ -238,6 +248,8 @@ QUIRGenQASM3Visitor::reportError(ASTBase const *location, | |||
| } | |||
|
|
|||
| void QUIRGenQASM3Visitor::visit(const ASTForStatementNode *node) { | |||
| switchCircuit(false, getLocation(node)); | |||
There was a problem hiding this comment.
I've been trying to think of a good way of avoiding the need to repeat switchCircuit in most methods as this could be brittle. I haven't thought of one yet.
Co-authored-by: Thomas Alexander <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Co-authored-by: Thomas Alexander <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
reza-j
reviewed
May 1, 2023
reza-j
reviewed
May 1, 2023
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
taalexander
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new operations to the QCS dialect,
declare_parameterandparameter_load. These operations are used to support input parameters, specifically those defined in QASM asThe PR also updates the
QUIRGenQASM3Visitorto handle input parameters as well as put real time operations intoquir.circuits.A command line option
--enable-parametersis used as a feature flag to gate use of the new features.New tests have been added to check the new features. All existing tests should pass without the new feature flag. Enabling support for the new feature throughout the stack and removing the feature flag is reserved for a future PR.
This PR does not change the handling of gate functions. That is
quir.circuitsare not inserted into the functions generated by QASM3gate h q { }statements.