Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Apache Httpclient4 to 5 in Spring Framework 6 upgrade #566

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

Laurens-W
Copy link
Contributor

@Laurens-W Laurens-W commented Aug 14, 2024

What's changed?

Include Apache HttpClient4 to HttpClient5 migration with Spring framework 6 migration

What's your motivation?

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.1-Release-Notes#dependency-management-for-apache-httpclient-4

Support for Apache HttpClient 4 with RestTemplate was removed in Spring Framework 6, in favor of Apache HttpClient 5. Spring Boot 3.0 includes dependency management for both HttpClient 4 and 5. Applications that continue to use HttpClient 4 can experience errors when using RestTemplate that are difficult to diagnose.

Spring Boot 3.1 removes dependency management for HttpClient 4 to encourage users to move to HttpClient 5 instead.

Have you considered any alternatives or workarounds?

While technically this would only be required when using Apache HttpClient with RestTemplate, the 3.1 release notes already hint at dependency management being dropped for httpclient 4.x

Any additional context

https://docs.spring.io/spring-boot/3.3/appendix/dependency-versions/coordinates.html
image

@Laurens-W Laurens-W self-assigned this Aug 14, 2024
@timtebeek timtebeek self-requested a review August 14, 2024 09:30
@timtebeek timtebeek marked this pull request as ready for review August 14, 2024 09:30
@timtebeek timtebeek added recipe Recipe requested boot-3.0 labels Aug 14, 2024
@timtebeek timtebeek changed the title Include apache httpclient4 to 5 in spring-framework-6 Include Apache Httpclient4 to 5 in Spring Framework 6 upgrade Aug 14, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Unlocks a next step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boot-3.0 recipe Recipe requested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants