Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When upgrading mockito also upgrade potential byte buddy dependencies #600

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

Laurens-W
Copy link
Contributor

What's changed?

Also upgrade byte buddy during mockito upgrade

What's your motivation?

If the version of byte-buddy and byte-buddy agent mismatch the mockmaker plugin cannot be initialized

Anything in particular you'd like reviewers to focus on?

Test coverage

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Laurens-W Laurens-W added the enhancement New feature or request label Sep 12, 2024
@Laurens-W Laurens-W self-assigned this Sep 12, 2024
@Laurens-W Laurens-W requested a review from timtebeek September 12, 2024 11:32
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Any reason this is still a draft?

@Laurens-W
Copy link
Contributor Author

Great work! Any reason this is still a draft?

Nope :)

@Laurens-W Laurens-W marked this pull request as ready for review September 12, 2024 12:43
@timtebeek timtebeek merged commit 52f5318 into main Sep 12, 2024
2 checks passed
@timtebeek timtebeek deleted the mockito-upgrade-bytebuddy branch September 12, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants