PowerMockitoMockStaticToMockito should not remove existing mockStatic initializer
#612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laurens-W
commented
Sep 30, 2024
| @@ -190,7 +190,9 @@ public J visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) | |||
|
|
|||
| if (MOCKED_STATIC_MATCHER.matches(mi)) { | |||
| determineTestGroups(); | |||
| if (!getCursor().getPath(o -> o instanceof J.Assignment || o instanceof J.Try.Resource).hasNext()) { | |||
| if (!getCursor().getPath(o -> o instanceof J.VariableDeclarations || | |||
There was a problem hiding this comment.
Am wondering whether this might be too broad
timtebeek
reviewed
Sep 30, 2024
src/test/java/org/openrewrite/java/testing/mockito/PowerMockitoMockStaticToMockitoTest.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Sep 30, 2024
|
Lets merge this iteration already; we can iterate further if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Mockito.mockStaticunexpectedly removed in rewrite-testing-frameworks:2.19.0 #611Anyone you would like to review specifically?
@timtebeek @knutwannheden
Checklist