More safeguards against failing Lombok initialization

openrewrite · Nov 5, 2024 · 3e068e6 · 3e068e6
1 parent 6f22790
commit 3e068e6
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/rewrite-java-17/src/main/java/org/openrewrite/java/isolated/ReloadableJava17Parser.java b/rewrite-java-17/src/main/java/org/openrewrite/java/isolated/ReloadableJava17Parser.java
@@ -53,7 +53,6 @@
 import javax.tools.StandardLocation;
 import java.io.*;
 import java.lang.reflect.Constructor;
-import java.lang.reflect.InvocationTargetException;
 import java.net.URI;
 import java.nio.charset.Charset;
 import java.nio.file.Path;
@@ -117,6 +116,7 @@ private ReloadableJava17Parser(
 
         LOMBOK:
         if (classpath != null && classpath.stream().anyMatch(it -> it.toString().contains("lombok"))) {
+            Processor lombokProcessor = null;
             try {
                 // https://projectlombok.org/contributing/lombok-execution-path
                 String systemClasspath = System.getProperty("java.class.path");
@@ -136,7 +136,6 @@ private ReloadableJava17Parser(
                         }
                     }
                     if (!found) {
-                        annotationProcessors = emptyList();
                         break LOMBOK;
                     }
                     System.setProperty("shadow.override.lombok", String.join(File.pathSeparator, overrideClasspath));
@@ -158,12 +157,12 @@ private ReloadableJava17Parser(
                         emptyList(),
                         singletonList("lombok.patcher.Symbols")
                 );
-                Processor lombokProcessor = (Processor) lombokShadowLoader.loadClass("lombok.core.AnnotationProcessor").getDeclaredConstructor().newInstance();
-                annotationProcessors = singletonList(lombokProcessor);
+                lombokProcessor = (Processor) lombokShadowLoader.loadClass("lombok.core.AnnotationProcessor").getDeclaredConstructor().newInstance();
                 Options.instance(context).put(Option.PROCESSOR, "lombok.launch.AnnotationProcessorHider$AnnotationProcessor");
-            } catch (ClassNotFoundException | NoSuchMethodException | InstantiationException | IllegalAccessException |
-                     InvocationTargetException e) {
-                throw new RuntimeException(e);
+            } catch (ReflectiveOperationException ignore) {
+                // Lombok was not found or could not be initialized
+            } finally {
+                annotationProcessors = lombokProcessor != null ? singletonList(lombokProcessor) : emptyList();
             }
         } else {
             annotationProcessors = emptyList();