fix: create dependencyResourceLoaders in 2 passes #4870
Merged
+15
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
In
scanJar
method inrewrite-core/src/main/java/org/openrewrite/config/Environment.java
, we are now creating the list of dependencyResourceLoaders in 2 passes to ensure all recipes are resolved.What's your motivation?
Recipe descriptors were missing due to transitive recipes failing to be resolved.
Anything in particular you'd like reviewers to focus on?
Are there any undesirable side effects from this change?
Anyone you would like to review specifically?
@timtebeek @sambsnyd @kmccarp