Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable parentheses level discovery for method calls for groovy 2 #4991

Conversation

jevanlingen
Copy link
Contributor

@jevanlingen jevanlingen commented Feb 6, 2025

What's changed?

Disable parentheses level discovery for methods for Groovy 2.

What's your motivation?

Groovy 2 does not contain the information we need, it always return -1 for the method calls object-expression. In older version of the groovy-parser this did not cause any exceptions, but since

it does.

Notice before PR #4951, the parser did also not support parentheses level discovery for methods for Groovy 2, but I did not throw an errors by chance.

Any additional context

Would be nice to have a real working solution for Groovy 2 as well. But let's focus on that at a later stage.

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this fixed ahead of the release, thanks!

@timtebeek timtebeek added the bug Something isn't working label Feb 6, 2025
@jevanlingen jevanlingen merged commit c2531c7 into main Feb 6, 2025
2 checks passed
@jevanlingen jevanlingen deleted the disable-parentheses-level-discovery-for-method-call-expression-for-groovy-2 branch February 6, 2025 11:49
@sambsnyd
Copy link
Member

sambsnyd commented Feb 6, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants