Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Edit api v3 #1615

Merged
merged 16 commits into from
Jan 27, 2025
Merged

feat: Edit api v3 #1615

merged 16 commits into from
Jan 27, 2025

Conversation

clepski
Copy link
Collaborator

@clepski clepski commented Jan 8, 2025

Support edit event API v2, according to API definition. Note the updated docs.

  • Added custom property createHistoryEntry to EditEventOptions for undo and redo
  • Edit event API v1 und edit action API are still supported
  • To support backwards compatibility all new types and functions have V2 as suffix and are exported from the core package

closes #1593

Copy link
Contributor

github-actions bot commented Jan 8, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-27 09:41 UTC

@clepski clepski marked this pull request as ready for review January 10, 2025 15:03
Copy link
Contributor

@michelguerin michelguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could plan to add your work on supporting the legacy event API (ie : event to event v1) to the @OpenEnergyTools package dedicated to the event API

Besides, do you know if we are planing to integrate this package instead of patching this instance ? Having a separate maintained package for this API seems to be a good option.

@clepski clepski merged commit ce39e2b into main Jan 27, 2025
6 checks passed
@clepski clepski deleted the feat/1593-edit-api-v3 branch January 27, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Edit API v3
3 participants