Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expectexception install #206

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Fix expectexception install #206

merged 1 commit into from
Jan 31, 2019

Conversation

znicholls
Copy link
Collaborator

Turns out I'm an idiot, this url business isn't needed, see thedataincubator/expectexception#1

Pull request

Please confirm that this pull request has done the following:

  • Tests added (N/A)
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added (N/A)

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

@znicholls znicholls requested a review from rgieseke January 30, 2019 21:23
@znicholls znicholls changed the base branch from master to tidy-up-notebooks January 30, 2019 21:35
@rgieseke
Copy link
Member

No need for self-deprecation! (Why doesn't pip tell one about it ...)

Should this go into master or tidy-up-notebooks?

@znicholls
Copy link
Collaborator Author

znicholls commented Jan 31, 2019 via email

@znicholls znicholls changed the base branch from tidy-up-notebooks to master January 31, 2019 09:49
Turns out I'm an idiot, this url business isn't needed, see thedataincubator/expectexception#1
@znicholls
Copy link
Collaborator Author

@rgieseke this one's a bit simpler now

@rgieseke rgieseke merged commit 5f1614d into master Jan 31, 2019
@rgieseke rgieseke deleted the znicholls-patch-1 branch January 31, 2019 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants