Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort 5 #87

Closed
wants to merge 21 commits into from
Closed

isort 5 #87

wants to merge 21 commits into from

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Jul 31, 2020

Pull request

Please confirm that this pull request has done the following:

  • Ops with scalars and vectors #82
  • Tests added (N/A)
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/openscm/scmdata/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/openscm/scmdata/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/openscm/scmdata/issues/YY>`_)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #87 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   94.72%   94.89%   +0.17%     
==========================================
  Files          15       15              
  Lines        1648     1665      +17     
  Branches      362      366       +4     
==========================================
+ Hits         1561     1580      +19     
+ Misses         59       58       -1     
+ Partials       28       27       -1     
Impacted Files Coverage Δ
src/scmdata/run.py 93.43% <100.00%> (+0.45%) ⬆️
src/scmdata/timeseries.py 90.42% <100.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d03f6...2098ad0. Read the comment docs.

lewisjared added a commit that referenced this pull request Jul 31, 2020
* isort-5:
  CHANGELOG
  Fix workflow for isort>5
@lewisjared
Copy link
Collaborator

Rebased and merged via cmdline as it didn't like the merged commits in #82

@lewisjared lewisjared closed this Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants