-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DeAngular][visualization][vislib] clean angular code in vis_type_vislib #2137
Labels
de-angular
de-angularize work
technical debt
If not paid, jeapardizes long-term success and maintainability of the repository.
visualizations
Issues and PRs related to visualizations
Comments
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Aug 12, 2022
* remove angular import and $scope from Binder class since there is no usage in the code Issue resolved: opensearch-project#2137 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Aug 12, 2022
* remove angular import and $scope from Binder class since there is no usage in the code Issue resolved: opensearch-project#2137 Signed-off-by: Anan Zhuang <[email protected]>
7 tasks
7 tasks
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Aug 15, 2022
* remove angular import and $scope from Binder class since there is no usage in the code Issue resolved: opensearch-project#2137 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
that referenced
this issue
Aug 25, 2022
* remove angular import and $scope from Binder class since there is no usage in the code Issue resolved: #2137 Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan Zhuang <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Sep 6, 2022
* remove angular import and $scope from Binder class since there is no usage in the code Issue resolved: #2137 Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> (cherry picked from commit 730a75a)
joshuarrrr
pushed a commit
that referenced
this issue
Sep 6, 2022
…#2270) * remove angular import and $scope from Binder class since there is no usage in the code Issue resolved: #2137 Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> (cherry picked from commit 730a75a) Co-authored-by: Anan Zhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
de-angular
de-angularize work
technical debt
If not paid, jeapardizes long-term success and maintainability of the repository.
visualizations
Issues and PRs related to visualizations
vis_type_vislib only has one file contains angular import and angular $scope.
From upstream, there are two places using Binder
In Tooltip, create a new Binder class
this.binder = new Binder()
(code reference)In Handler, create a new Binder class
this.binder = new Binder()
(code reference)There is no place to use angular $scope in the vis_type_vislib. Therefore, we could do an easy removing.
This issue is part of #1560 .
The text was updated successfully, but these errors were encountered: