Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] final pass reference fixes and package version update #216

Merged
merged 2 commits into from
Mar 22, 2021
Merged

[Cleanup] final pass reference fixes and package version update #216

merged 2 commits into from
Mar 22, 2021

Conversation

boktorbb
Copy link
Contributor

Signed-off-by: Bishoy Boktor [email protected]

@boktorbb boktorbb requested review from mihirsoni and ananzh March 22, 2021 17:20
@odfe-release-bot
Copy link

✅   DCO Check Passed

mihirsoni
mihirsoni previously approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

kavilla
kavilla previously approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good, there might have been a meeting where we were told to just update all elastic references. Just a few comments though. An overall comment: if we are updating elastic did we want to update elasticsearch and kibana?

package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/osd-ace/src/ace/modes/lexer_rules/opensearch_sql_highlight_rules.ts Show resolved Hide resolved
packages/osd-dev-utils/certs/README.md Show resolved Hide resolved
src/plugins/vis_type_vega/public/data_model/vega_parser.ts Outdated Show resolved Hide resolved
test/functional/apps/getting_started/_shakespeare.js Show resolved Hide resolved
ananzh
ananzh previously approved these changes Mar 22, 2021
View reviewed changes
Address PR comments
c87962e 
Signed-off-by: Bishoy Boktor <[email protected]>
@boktorbb boktorbb dismissed stale reviews from ananzh, kavilla, and mihirsoni via c87962e March 22, 2021 17:33
@odfe-release-bot
Copy link

✅   DCO Check Passed

kavilla
kavilla approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@boktorbb boktorbb merged commit 425c1d4 into opensearch-project:main Mar 22, 2021
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 13, 2023
@Hailong-am
[API] Delete saved objects by workspace (opensearch-project#216)
1e5c81e 
* Delete saved objects by workspace

Signed-off-by: Hailong Cui <[email protected]>

fix osd boostrap

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

* fix can't delete workspace due to invalid permission

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 7773811)
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 13, 2023
@Hailong-am
[API] Delete saved objects by workspace (opensearch-project#216)
7773811 
* Delete saved objects by workspace

Signed-off-by: Hailong Cui <[email protected]>

fix osd boostrap

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

* fix can't delete workspace due to invalid permission

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 13, 2023
@Hailong-am
[API] Delete saved objects by workspace (opensearch-project#216)
ebd9767 
* Delete saved objects by workspace

Signed-off-by: Hailong Cui <[email protected]>

fix osd boostrap

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

* fix can't delete workspace due to invalid permission

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 7773811)
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Feb 22, 2024
@Hailong-am @wanglam
[API] Delete saved objects by workspace (opensearch-project#216)
0bc69a7 
* Delete saved objects by workspace

Signed-off-by: Hailong Cui <[email protected]>

fix osd boostrap

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

* fix can't delete workspace due to invalid permission

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Mar 4, 2024
@Hailong-am
[API] Delete saved objects by workspace (opensearch-project#216)
bf9821d 
* Delete saved objects by workspace

Signed-off-by: Hailong Cui <[email protected]>

fix osd boostrap

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

* fix can't delete workspace due to invalid permission

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Mar 4, 2024
@Hailong-am
[API] Delete saved objects by workspace (opensearch-project#216)
afb3701 
* Delete saved objects by workspace

Signed-off-by: Hailong Cui <[email protected]>

fix osd boostrap

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

* fix can't delete workspace due to invalid permission

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
SuZhou-Joe pushed a commit that referenced this pull request Mar 11, 2024
@Hailong-am
[Workspace] Delete saved objects by workspace (#6013)
735424b 
* [API] Delete saved objects by workspace (#216)

* Delete saved objects by workspace

Signed-off-by: Hailong Cui <[email protected]>

fix osd boostrap

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

* fix can't delete workspace due to invalid permission

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

* update test case

Signed-off-by: Hailong Cui <[email protected]>

* Add change log

Signed-off-by: Hailong Cui <[email protected]>

* update change log format

Signed-off-by: Hailong Cui <[email protected]>

* update method comments to make it more clear

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
@Hailong-am @SuZhou-Joe
[API] Delete saved objects by workspace (opensearch-project#216)
722fc28 
* Delete saved objects by workspace

Signed-off-by: Hailong Cui <[email protected]>

fix osd boostrap

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

* fix can't delete workspace due to invalid permission

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Hailong-am added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Apr 12, 2024
@Hailong-am
[Workspace] Delete saved objects by workspace (opensearch-project#6013)
f0ad141 
* [API] Delete saved objects by workspace (opensearch-project#216)

* Delete saved objects by workspace

Signed-off-by: Hailong Cui <[email protected]>

fix osd boostrap

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

* fix can't delete workspace due to invalid permission

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

* update test case

Signed-off-by: Hailong Cui <[email protected]>

* Add change log

Signed-off-by: Hailong Cui <[email protected]>

* update change log format

Signed-off-by: Hailong Cui <[email protected]>

* update method comments to make it more clear

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 735424b)
SuZhou-Joe added a commit that referenced this pull request Apr 14, 2024
@Hailong-am @SuZhou-Joe
[Backport 2.x] [Workspace] Delete saved objects by workspace (#6424)
d31d9de 
* [Workspace] Delete saved objects by workspace (#6013)

* [API] Delete saved objects by workspace (#216)

* Delete saved objects by workspace

Signed-off-by: Hailong Cui <[email protected]>

fix osd boostrap

Signed-off-by: Hailong Cui <[email protected]>

* add unit test

Signed-off-by: Hailong Cui <[email protected]>

* fix can't delete workspace due to invalid permission

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>

* update test case

Signed-off-by: Hailong Cui <[email protected]>

* Add change log

Signed-off-by: Hailong Cui <[email protected]>

* update change log format

Signed-off-by: Hailong Cui <[email protected]>

* update method comments to make it more clear

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 735424b)

* Update CHANGELOG.md

Co-authored-by: SuZhou-Joe <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@kavilla kavilla kavilla approved these changes

@mihirsoni mihirsoni mihirsoni approved these changes

Assignees
No one assigned
Labels
rename
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@boktorbb @odfe-release-bot @mihirsoni @kavilla @ananzh